[richfaces-issues] [JBoss JIRA] Resolved: (RF-7984) I would be nice to have the BaseXML redirecting-code in a util-class

Tue Jun 8 10:02:38 EDT 2010

     [ https://jira.jboss.org/browse/RF-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nick Belaevski resolved RF-7984.
--------------------------------

    Fix Version/s:     (was: 4.0.0.Milestone1)
       Resolution: Out of Date

Filter is not used in RF anymore. 

> I would be nice to have the BaseXML redirecting-code in a util-class
> --------------------------------------------------------------------
>
>                 Key: RF-7984
>                 URL: https://jira.jboss.org/browse/RF-7984
>             Project: RichFaces
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: core
>    Affects Versions: 3.3.2.GA
>            Reporter: Andreas Höhmann
>            Assignee: Nick Belaevski
>            Priority: Minor
>
> I wrote a special spring security entry point to handle missing authentication *after* a a4j-request:
>   /**
>    * {@inheritDoc}
>    */
>   @Override
>   protected void sendRedirect(final HttpServletRequest theRequest, final HttpServletResponse theResponse,
>       final String theUrl) throws IOException {
>     if (!isAjaxRequest(theRequest)) {
>       LOG.debug("normal redirect to " + theUrl);
>       super.sendRedirect(theRequest, theResponse, theUrl);
>     } else {
>       LOG.debug("ajax redirect to " + theUrl);
>       final FilterServletResponseWrapper servletResponseWrapper = new FilterServletResponseWrapper(theResponse);
>       final Writer output = resetResponse(theResponse, servletResponseWrapper, "redirect");
>       theResponse.setHeader(AjaxContainerRenderer.AJAX_LOCATION_HEADER, theUrl);
>       // For buggy XmlHttpRequest realisations repeat headers in
>       // <meta>
>       output.write("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n"
>           + "<html xmlns=\"http://www.w3.org/1999/xhtml\"><head>" + "<meta name=\""
>           + AjaxContainerRenderer.AJAX_FLAG_HEADER + "\" content=\"redirect\" />" + "<meta name=\""
>           + AjaxContainerRenderer.AJAX_LOCATION_HEADER + "\" content=\"" + theUrl + "\" />" + "</head></html>");
>       output.flush();
>       theResponse.flushBuffer();
>     }
>   }
> Currently i'm must copy the redirecting-code from org.ajax4jsf.webapp.BaseXMLFilter to reuse it.
> It would be nice to have a "A4JResponseUtils" with this methods:
> - boolean isAjaxRequest(final ServletRequest request)
> - void sendRedirect(final HttpServletRequest theRequest, final HttpServletResponse theResponse, final String theUrl)
> The advantage of such a utils-class would be a always compatibly thirdparty code (integration code), if the redirecting-code changes in a4j my code should still work :D

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira