[richfaces-issues] [JBoss JIRA] Assigned: (RF-9172) Calendar: pre-promotion code review

Wed Nov 3 15:41:01 EDT 2010

     [ https://jira.jboss.org/browse/RF-9172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Mishin reassigned RF-9172:
-------------------------------------

    Assignee: Andrey Markhel  (was: Konstantin Mishin)

I have found next problems:
1. CurrentDate is updated at Process Validations phase but should at Update Model Values. Other code related with this attribute isn't very clear and can have some problems, particularly method broadcast is a wrong place for converting and updating.  I suggest to use the same approach of working with currentDate like in case of working with value of UIInput.
2. Some of CCS-classes doesn't comply with our naming convention.
3. JS code has a lot of "magic" numbers and hasn't code-style.

> Calendar: pre-promotion code review
> -----------------------------------
>
>                 Key: RF-9172
>                 URL: https://jira.jboss.org/browse/RF-9172
>             Project: RichFaces
>          Issue Type: Sub-task
>      Security Level: Public(Everyone can see) 
>          Components: component-input
>    Affects Versions: 4.0.0.Milestone2
>            Reporter: Ilya Shaikovsky
>            Assignee: Andrey Markhel
>             Fix For: 4.0.0.Milestone4
>
>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira