[richfaces-issues] [JBoss JIRA] (RF-11548) showcase - define our own error messages for rich:message, rich:messages and other components to have consistent error messages

[Juraj Huska (Issue Comment Edited) (JIRA)]

    [ https://issues.jboss.org/browse/RF-11548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635803#comment-12635803 ] 

Juraj Huska edited comment on RF-11548 at 12/7/11 4:20 AM:
-----------------------------------------------------------

I have just done step by step what was written here:
http://blogs.oracle.com/johnc/entry/more_jsf_validation_custom_error

*This should achieve that on all containers there are consistent JSF validation messages.*

This is commit which contains these changes:
https://github.com/jhuska/showcase/commit/34d8f6d1b09d81ac21ab6b87b38a27890ad3a3b4

*The only drawback*, now, is that error messages contains the label of the component which generated it. Some of the labels are generated dynamically, which causes sometimes ugly validation messages, like j_idt221:age: 'da' must be a number between -2147483648 and 2147483647 Example: 9346

IMHO this can be solved in three ways:
-generate IDs and names attributes not dynamically
-delete parameter for message which determines from which input it was generated which is not good, mainly for rich:messages component, where user than will not know where the message comes from
                
      was (Author: jhuska):
    I have just done step by step what was written here:
http://blogs.oracle.com/johnc/entry/more_jsf_validation_custom_error

This should achieve that on all containers there are consistent JSF validation messages.

This is commit which contains these changes:
https://github.com/jhuska/showcase/commit/34d8f6d1b09d81ac21ab6b87b38a27890ad3a3b4

*The only drawback*, now, is that each message takes a parameter with the label of component which generated particular messages. Some of the labels are generated dynamically, which causes sometimes ugly validation messages, like j_idt221:age: 'da' must be a number between -2147483648 and 2147483647 Example: 9346

IMHO this can be solved in three ways:
-generate IDs and names attributes not dynamically
-delete parameter for message which determines from which input it was generated which is not good, mainly for rich:messages component, where user than will not know where the message comes from
-let this small issue be

Should I make pull request with the small described ugliness ?
                  
> showcase - define our own error messages for rich:message, rich:messages and other components to have consistent error messages
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: RF-11548
>                 URL: https://issues.jboss.org/browse/RF-11548
>             Project: RichFaces
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: showcase
>    Affects Versions: 4.1.0.Milestone3
>         Environment: showcase
>            Reporter: Juraj Huska
>            Assignee: Lukáš Fryč
>            Priority: Minor
>             Fix For: 4.2.0.Tracking
>
>
> The standard error messages provided by mojarra are changed from one version to another. 
> For example there is quiet small change, but causes that for example in JBoss AS 6.0.0.Final I have this error message:
> Name: Validation Error: *Value* is less than allowable minimum of '3'
> and on JBoss AS 7.0.2.Final I have:
> Name: Validation Error: *Length* is less than allowable minimum of '3'
> this causes some problems when testing and also IMHO it would look better with unified error messages for all components and containers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira