[richfaces-issues] [JBoss JIRA] (RF-11807) TabPanel does not accept Comment as XML-child

[Brian Leathem (Resolved) (JIRA)]

     [ https://issues.jboss.org/browse/RF-11807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Leathem resolved RF-11807.
--------------------------------

      Assignee: Brian Leathem
    Resolution: Done


Thanks for taking the time to report and isolate this issue!
----
Added an instanceof check before casting the AbstractTab
                
> TabPanel does not accept Comment as XML-child
> ---------------------------------------------
>
>                 Key: RF-11807
>                 URL: https://issues.jboss.org/browse/RF-11807
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: component-panels-layout-themes
>    Affects Versions: 4.1.0.CR2
>         Environment: Win 7 64 Bit
>            Reporter: Friedhelm Kuehn
>            Assignee: Brian Leathem
>            Priority: Minor
>              Labels: richfaces
>             Fix For: 4.1.1.Final
>
>
> Not big problem - just to let you know: TabPanel does not accept XML-Comment as child - I think it should. 
> Example:
> {code}
> <rich:tabPanel 	id="Source_TabPanel_South" headerAlignment="left" headerPosition="top" switchType="client" style="width:100%;height:100%;">
>     <!--  this does not work !!! -->           					
>     <rich:tab id="Source_Console_Tab">
> {code}
> Result:  
> {code}
> Class-Cast Exception: com.sun.faces.facelets.compiler.UIInstructions cannot be cast to org.richfaces.component.AbstractTab
> at org.richfaces.renderkit.html.TabPanelRenderer.doEncodeEnd(TabPanelRenderer.java:257)
> {code}
> Statement there:                 AbstractTab tab = (AbstractTab) child;
> Proposed solution : Check castability to AbstractTab before and f.e. silently ignore others (at least UIInstructions)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira