[richfaces-issues] [JBoss JIRA] Commented: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference

[Andy Schwartz (JIRA)]

    [ https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580959#comment-12580959 ] 

Andy Schwartz commented on RF-10154:
------------------------------------

Both Mojarra (as of 2.0.4) and MyFaces (as of today) support an interim "skip iteration" solution for 2.0 via the "javax.faces.visit.SKIP_ITERATION" FacesContext property.  See MyFaces dev discussion here:

http://markmail.org/search/?q=list:org.apache.myfaces.dev#query:list%3Aorg.apache.myfaces.dev+page:2+mid:rna766osytyqudfg+state:results

And related issue here:

MYFACES-3036 Support SKIP_ITERATION FacesContext propert
https://issues.apache.org/jira/browse/MYFACES-3036

If UIDataAdaptor.requiresRowIteration was updated to honor this property, I believe that this would avoid the DebugPhaseListener tree visit failure.  More details here:

MYFACES-3033 Improve DebugPhaseListener for UIData and SKIP_ITERATION
https://issues.apache.org/jira/browse/MYFACES-3033

> UIDataAdaptor vs. UIData visitTee small difference
> --------------------------------------------------
>
>                 Key: RF-10154
>                 URL: https://issues.jboss.org/browse/RF-10154
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: component-tables
>    Affects Versions: 4.0.0.Milestone5
>         Environment: RichFaces 4.0.X trunk, svn rev. 20913
>            Reporter: Martin Kočí
>            Assignee: Nick Belaevski
>            Priority: Minor
>             Fix For: 4.Next
>
>
> <r:extendedDataTable var="zeile">
> <r:column>
>   <h:outputText rendered="#{fasole.method(zeile)}"
> </r:column>
> </r:extendedDataTable>
> +
>  org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with VisitHint SKIP_UNRENDERED (in render response phase for example)
> Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext, VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext, callback);-> it will visit h:outputText component and test if is rendered -> #{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter and causes an unexpected NPE
> j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces), UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira