[richfaces-issues] [JBoss JIRA] Commented: (RF-9924) Panel menu: rename icon attributes
Lukas Fryc (JIRA)
jira-events at lists.jboss.org
Tue Jan 11 05:19:49 EST 2011
[ https://issues.jboss.org/browse/RF-9924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574600#comment-12574600 ]
Lukas Fryc commented on RF-9924:
--------------------------------
Please consider that the Group and Item itself have follows other naming principle:
e.g.
Panel Menu - @groupCollapseIconLeft
Panel Menu Group - @iconLeftCollapsed
The attributes should be named consistently across Panel Menu and it's children.
I personally then prefer renaming Panel Menu attributes itself, e.g. to @groupIconLeftCollapsed (it is easier to read in the code).
> Panel menu: rename icon attributes
> ----------------------------------
>
> Key: RF-9924
> URL: https://issues.jboss.org/browse/RF-9924
> Project: RichFaces
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.0.0.Milestone4
> Environment: RichFaces 4.0.0-SNAPSHOT r.20396
> Reporter: Pavol Pitonak
> Assignee: Alex Kolonitsky
> Fix For: 4.0.0.CR1
>
>
> Replace "Collapse" with "Collapsed", "Disable" with "Disabled" and "Expand" with "Expanded" in following attributes of rich:panelMenu:
> topGroupCollapseIconLeft
> topGroupCollapseIconRight
> topGroupDisableClass
> topGroupDisableIconLeft
> topGroupDisableIconRight
> topGroupExpandIconLeft
> topGroupExpandIconRight
> topItemDisableClass
> topItemDisableIconLeft
> topItemDisableIconRight
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the richfaces-issues
mailing list