[richfaces-issues] [JBoss JIRA] Commented: (RF-6456) [SuggestionBox] SuggestionAction called twice during request if usingSuggestObjects = true

[Nick Belaevski (JIRA)]

    [ https://issues.jboss.org/browse/RF-6456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575245#comment-12575245 ] 

Nick Belaevski commented on RF-6456:
------------------------------------

Having "null" string being passed the second time is a problem, also the second call is not necessary as there are no selected values in the default case ('tokens' attribute is unset). 

> [SuggestionBox] SuggestionAction called twice during request if usingSuggestObjects = true
> ------------------------------------------------------------------------------------------
>
>                 Key: RF-6456
>                 URL: https://issues.jboss.org/browse/RF-6456
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 3.3.0
>            Reporter: Gerrit Brehmer
>            Assignee: Nick Belaevski
>             Fix For: Future_3.X
>
>
> SuggestionAction is called twice, if usingSuggestObjects is activated. I looked into the sourcecode and found the two calls:
> - Action with value from request/input field (method setupValue - setValue(suggestingAction.invoke(context.getELContext(), new Object[]{submittedValue}));)
> - Action with "null" as string (method getRequestValuesData - setValue(suggestingAction.invoke(context.getELContext(), new Object[]{requestedValue}));)
> (SourceCode from UiSuggestionBox.java Tag 3.3.0)
> Is the second call really necessary? Because we call an expensive backend method (200ms - 7000ms for address suggest) this makes a noticable delay for the user
> Our workaround is to return an empty list for the second call, which doesn't change the behaviour

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira