[richfaces-issues] [JBoss JIRA] Commented: (RF-10712) processUpload vs. processFileUpload - naming conventions

Ilya Shaikovsky (JIRA) jira-events at lists.jboss.org
Thu Mar 10 12:01:46 EST 2011


    [ https://issues.jboss.org/browse/RF-10712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587210#comment-12587210 ] 

Ilya Shaikovsky commented on RF-10712:
--------------------------------------

changes which should be made:

FileUploadListener.processFileUpload(FileUploadEvent)
TreeSelectionChangeListener.processTreeSelectionChange(TreeSelectionChangeEvent)
TreeToggleListener.processTreeToggle(TreeToggleEvent)
ToggleListener -> CollapsibleSubTableToggleListener.processCollapsibleSubTableToggle(CollapsibleSubTableToggleEvent)
DataScrollListener.processDataScroll(DataScrollEvent)
ValidatorListener -> please check. Seems not used now at all. Then remove it and name will be reviewed after we will need to add it.
additionally - remove PaggingListener (and event)

> processUpload vs. processFileUpload - naming conventions
> --------------------------------------------------------
>
>                 Key: RF-10712
>                 URL: https://issues.jboss.org/browse/RF-10712
>             Project: RichFaces
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: compatibility
>    Affects Versions: 4.0.0.CR1
>         Environment: richfaces 4.0.X branch
>            Reporter: Martin Kočí
>            Assignee: Alex Kolonitsky
>             Fix For: 4.0.0.Final
>
>
> method org.richfaces.event.FileUploadListener.processUpload(FileUploadEvent) should be 
> FileUploadListener.processFileUpload - with the "File" word in the middle.
> The unspecified JSF convention is:
> * logical name ("FileUpload")
> * listener: logical name + "Listener" ("FileUploadListener")
> * event: logical name + "Event" ("FileUploadEvent")
> * method "process" + logical name ("processFileUpload")

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



More information about the richfaces-issues mailing list