[richfaces-issues] [JBoss JIRA] Commented: (RF-10221) Error when opening a popup panel

[Gleb Galkin (JIRA)]

    [ https://issues.jboss.org/browse/RF-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587380#comment-12587380 ] 

Gleb Galkin commented on RF-10221:
----------------------------------

James, sorry, it was a misunderstanding. Thank you very much for your attentiveness, you're right about ready() method and its parameter. I've fixed this API as follows:

        showPopupPanel : function (id, opts, event) {
            richfaces.Event.ready(function(){richfaces.$(id).show()});
        },

        hidePopupPanel : function (id, opts, event) {
            richfaces.Event.ready(function(){richfaces.$(id).hide()});
        }

Also I've verified it as follows and everything works OK:
<script type="text/javascript">
  RichFaces.ui.PopupPanel.showPopupPanel('form:popup', {});
</script>
<h:form id="form">
  <rich:popupPanel id="popup" />
</h:form>

> Error when opening a popup panel
> --------------------------------
>
>                 Key: RF-10221
>                 URL: https://issues.jboss.org/browse/RF-10221
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: component-panels-layout-themes
>    Affects Versions: 4.0.0.Milestone5
>         Environment: myfaces 2.0.3, tomcat 6
>            Reporter: James G
>            Assignee: Gleb Galkin
>              Labels: popupPanel
>             Fix For: 4.0.0.Final
>
>
> When I call show or hide for a popup panel I get the following error: "fn is undefined" from firefox.
> I believe the offening code is:  (in popupPanel.js)
>    showPopupPanel : function (id, opts, event) {
>       $(document).ready(richfaces.$(id).show());
>    },
>    hidePopupPanel : function (id, opts, event) {
>       $(document).ready(richfaces.$(id).hide());
>    }
> 		
> It should probably be something more like:
>    showPopupPanel : function (id, opts, event) {
>       $(document).ready( function() { richfaces.$(id).show() } );
>    },
>    hidePopupPanel : function (id, opts, event) {
>       $(document).ready( function(){ richfaces.$(id).hide() } );
>    }

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira