[richfaces-issues] [JBoss JIRA] Issue Comment Edited: (RF-10712) Refactoring Listeners classes, methods and Event names according to standard JSF convention. [WAS processUpload vs. processFileUpload - naming conventions]

[Alex Kolonitsky (JIRA)]

    [ https://issues.jboss.org/browse/RF-10712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587549#comment-12587549 ] 

Alex Kolonitsky edited comment on RF-10712 at 3/12/11 9:18 AM:
---------------------------------------------------------------

The following classes were changed:

DataScrollerSource -> DataScrollSource

Expandable interface
Expandable.addToggleListener(ToggleListener listener) -> Expandable.addCollapsibleSubTableToggleListener(CollapsibleSubTableToggleListener listener)
Expandable.removeToggleListener(ToggleListener listener) -> Expandable.removeCollapsibleSubTableToggleListener(CollapsibleSubTableToggleListener listener)
ToggleListener[] Expandable.getToggleListeners -> CollapsibleSubTableToggleListener[] Expandable.getCollapsibleSubTableToggleListener


      was (Author: Alex.Kolonitsky):
    DataScrollerSource -> DataScrollSource

Expandable interface
Expandable.addToggleListener(ToggleListener listener) -> Expandable.addCollapsibleSubTableToggleListener(CollapsibleSubTableToggleListener listener)
Expandable.removeToggleListener(ToggleListener listener) -> Expandable.removeCollapsibleSubTableToggleListener(CollapsibleSubTableToggleListener listener)
ToggleListener[] Expandable.getToggleListeners -> CollapsibleSubTableToggleListener[] Expandable.getCollapsibleSubTableToggleListener

  
> Refactoring Listeners classes, methods and Event names according to standard JSF convention. [WAS processUpload vs. processFileUpload - naming conventions]
> -----------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: RF-10712
>                 URL: https://issues.jboss.org/browse/RF-10712
>             Project: RichFaces
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: compatibility
>    Affects Versions: 4.0.0.CR1
>         Environment: richfaces 4.0.X branch
>            Reporter: Martin Kočí
>            Assignee: Alex Kolonitsky
>             Fix For: 4.0.0.Final
>
>
> method org.richfaces.event.FileUploadListener.processUpload(FileUploadEvent) should be 
> FileUploadListener.processFileUpload - with the "File" word in the middle.
> The unspecified JSF convention is:
> * logical name ("FileUpload")
> * listener: logical name + "Listener" ("FileUploadListener")
> * event: logical name + "Event" ("FileUploadEvent")
> * method "process" + logical name ("processFileUpload")

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira