[richfaces-issues] [JBoss JIRA] Updated: (RF-10762) dataScroller: inconsistency between facets names in code contants and ones used for rendering.

[Ilya Shaikovsky (JIRA)]

     [ https://issues.jboss.org/browse/RF-10762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ilya Shaikovsky updated RF-10762:
---------------------------------

    Description: 
functionally all is working fine. And documentation (need to check b.t.w.) will help the user to define right facets.

But some of the community guys according to questions among the thread and myself b.t.w. do not open docs for minor checks but looking into UI class code instead. 

There are next constants:
    public static final String FIRST_FACET_NAME = "first";

    public static final String LAST_FACET_NAME = "last";

    public static final String NEXT_FACET_NAME = "next";

    public static final String PREVIOUS_FACET_NAME = "previous";
    
    public static final String FAST_FORWARD_FACET_NAME = "fastforward";

    public static final String FAST_REWIND_FACET_NAME = "fastrewind";

    public static final String FIRST_DISABLED_FACET_NAME = "first_disabled";

    public static final String LAST_DISABLED_FACET_NAME = "last_disabled";

but them not used in renderer and just string constant used there. And moreover fastrewind and fastforward used in camel case.

So proposed to use constant for consistency. But change ones which not the same as currently in renderer in order not to break compatibility,.

  was:
functionally all is working fine. And documentation (need to check b.t.w.) will help the user to define right facets.

But some of the community guys according to questions among the thread and myself b.t.w. do not open docs for minor checks but looking into UI class code instead. 

There are 



> dataScroller: inconsistency between facets names in code contants and ones used for rendering.
> ----------------------------------------------------------------------------------------------
>
>                 Key: RF-10762
>                 URL: https://issues.jboss.org/browse/RF-10762
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: component-tables
>    Affects Versions: 4.0.0.Final
>            Reporter: Ilya Shaikovsky
>            Assignee: Ilya Shaikovsky
>            Priority: Minor
>
> functionally all is working fine. And documentation (need to check b.t.w.) will help the user to define right facets.
> But some of the community guys according to questions among the thread and myself b.t.w. do not open docs for minor checks but looking into UI class code instead. 
> There are next constants:
>     public static final String FIRST_FACET_NAME = "first";
>     public static final String LAST_FACET_NAME = "last";
>     public static final String NEXT_FACET_NAME = "next";
>     public static final String PREVIOUS_FACET_NAME = "previous";
>     
>     public static final String FAST_FORWARD_FACET_NAME = "fastforward";
>     public static final String FAST_REWIND_FACET_NAME = "fastrewind";
>     public static final String FIRST_DISABLED_FACET_NAME = "first_disabled";
>     public static final String LAST_DISABLED_FACET_NAME = "last_disabled";
> but them not used in renderer and just string constant used there. And moreover fastrewind and fastforward used in camel case.
> So proposed to use constant for consistency. But change ones which not the same as currently in renderer in order not to break compatibility,.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira