[richfaces-issues] [JBoss JIRA] Updated: (RF-10775) ignoreDupResponce: implemented wrong according to code review

[Nick Belaevski (JIRA)]

     [ https://issues.jboss.org/browse/RF-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nick Belaevski updated RF-10775:
--------------------------------

         Assignee: Konstantin Mishin  (was: Nick Belaevski)
    Fix Version/s: 4.0.0.Final
         Priority: Critical  (was: Major)


> ignoreDupResponce: implemented wrong according to code review
> -------------------------------------------------------------
>
>                 Key: RF-10775
>                 URL: https://issues.jboss.org/browse/RF-10775
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: core
>    Affects Versions: 4.0.0.CR1
>            Reporter: Ilya Shaikovsky
>            Assignee: Konstantin Mishin
>            Priority: Critical
>             Fix For: 4.0.0.Final
>
>
> In order to ignore dom updates two conditions should be met:
> 1) next request to be sent should be "similar" to the current from which the responce came
> 2) current should have ignoreDupRespoce = true. 
> but according to current code 1) step checked in a wrong way. The *last* event is get instead of the next.
> Code:
>  isIgnoreResponse: function () {
> 	var lastEntry = getLastEntry();
> 	return lastEntry && lastRequestedEntry.isIgnoreDupResponses() && lastRequestedEntry.getRequestGroupId() == lastEntry.getRequestGroupId();
> },
>  var getLastEntry = function () {
> 	var lastIdx = items.length - 1;
> 	return items[lastIdx];
> };

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira