[richfaces-issues] [JBoss JIRA] (RF-12140) Upgrade com.google.guava:guava from 10.x to 11.x

[Brian Leathem (JIRA)]

    [ https://issues.jboss.org/browse/RF-12140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682735#comment-12682735 ] 

Brian Leathem commented on RF-12140:
------------------------------------

Our intention is to track the Google Guava version that the JBoss AS team is using.  Have they upgraded to version 11 as well?
                
> Upgrade com.google.guava:guava from 10.x to 11.x 
> -------------------------------------------------
>
>                 Key: RF-12140
>                 URL: https://issues.jboss.org/browse/RF-12140
>             Project: RichFaces
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 4.2.0.Final
>            Reporter: Marek Novotny
>
> I had to upgrade guava to 11.x version and this breaks the CDK Generator tests in org.richfaces.cdk.templatecompiler.parser.el.test.ELParserTest
> I have to change the usage of ImmutableSet.of to ImmutableSet.copyOf.
> {noformat}
> diff --git a/generator/src/test/java/org/richfaces/cdk/templatecompiler/parser/el/test/ELParserTest.java b/generator/src/test/java/org/richfaces/cdk/templatecompiler/parser/el/test/ELParserTest.java
> index 472a34d..6039aff 100644
> --- a/generator/src/test/java/org/richfaces/cdk/templatecompiler/parser/el/test/ELParserTest.java
> +++ b/generator/src/test/java/org/richfaces/cdk/templatecompiler/parser/el/test/ELParserTest.java
> @@ -109,7 +109,7 @@
>          }
>          for (HelperMethod helperMethod : parseExpression.getRequiredMethods()) {
>              assertTrue("Unexpected helper method " + helperMethod.getName(),
> -                    Iterables.contains(ImmutableSet.of(requiredMethods), helperMethod));
> +                    Iterables.contains(ImmutableSet.copyOf(requiredMethods), helperMethod));
>          }
>          return parseExpression;
>      }
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira