[richfaces-issues] [JBoss JIRA] (RF-12001) Rich-DataTable: RenderPhaseDataScrollerVisitor swallows exceptions when thrown in isRendered

[Brian Leathem (JIRA)]

     [ https://issues.jboss.org/browse/RF-12001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Leathem updated RF-12001:
-------------------------------

    Fix Version/s: 3.Future
      Description: 
We implemented our own SerializableDataModel.
This datamodel throws an Exception in case the backend is not available or has some technical issues.

Our exception is swallowed by 
org.richfaces.component.RenderPhaseDataScrollerVisitor.isRendered(List<UIComponent>).

Is there a reason why all exception are catched in this situation?

{code}
	private static boolean isRendered(List<UIComponent> components) {
		boolean rendered;
		
		for (UIComponent component : components) {
			rendered = false;

			try {
				rendered = component.isRendered();
			} catch (Exception e) {
				//ignore that
				if (log.isDebugEnabled()) {
					log.debug(e.getLocalizedMessage(), e);
				}
			}
			
			if (!rendered) {
				return false;
			}
		}
		
		return true;
	}
{code}

  was:
We implemented our own SerializableDataModel.
This datamodel throws an Exception in case the backend is not available or has some technical issues.

Our exception is swallowed by 
org.richfaces.component.RenderPhaseDataScrollerVisitor.isRendered(List<UIComponent>).

Is there a reason why all exception are catched in this situation?


	private static boolean isRendered(List<UIComponent> components) {
		boolean rendered;
		
		for (UIComponent component : components) {
			rendered = false;

			try {
				rendered = component.isRendered();
			} catch (Exception e) {
				//ignore that
				if (log.isDebugEnabled()) {
					log.debug(e.getLocalizedMessage(), e);
				}
			}
			
			if (!rendered) {
				return false;
			}
		}
		
		return true;
	}


    
> Rich-DataTable: RenderPhaseDataScrollerVisitor swallows exceptions when thrown in isRendered
> --------------------------------------------------------------------------------------------
>
>                 Key: RF-12001
>                 URL: https://issues.jboss.org/browse/RF-12001
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 3.3.1
>         Environment: Liferay 5.2.4, Facelets, JSF 1.2
>            Reporter: Markus Staab
>             Fix For: 3.Future
>
>
> We implemented our own SerializableDataModel.
> This datamodel throws an Exception in case the backend is not available or has some technical issues.
> Our exception is swallowed by 
> org.richfaces.component.RenderPhaseDataScrollerVisitor.isRendered(List<UIComponent>).
> Is there a reason why all exception are catched in this situation?
> {code}
> 	private static boolean isRendered(List<UIComponent> components) {
> 		boolean rendered;
> 		
> 		for (UIComponent component : components) {
> 			rendered = false;
> 			try {
> 				rendered = component.isRendered();
> 			} catch (Exception e) {
> 				//ignore that
> 				if (log.isDebugEnabled()) {
> 					log.debug(e.getLocalizedMessage(), e);
> 				}
> 			}
> 			
> 			if (!rendered) {
> 				return false;
> 			}
> 		}
> 		
> 		return true;
> 	}
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira