[richfaces-issues] [JBoss JIRA] (RF-8608) rich:effect name does not properly create the JS function to be called

[Marek Będkowski (JIRA)]

    [ https://issues.jboss.org/browse/RF-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675300#comment-12675300 ] 

Marek Będkowski edited comment on RF-8608 at 3/8/12 4:19 PM:
-------------------------------------------------------------

Hi

Since the problem still exists in 3.3.3.Final I decided to prepare a patch (processEffect.js.patch) to the formentioned processEffect.js file - I got rid of 'with' and 'eval' evils and seems to do the trick :)

@Thomas - I tried swapping variable name from params to myparams but it made no difference.

                
      was (Author: bendi):
    If you experience this problem and still using richfaces 3.3.x - please ignore comment above by Thomas Cerny, swapping local variable names seemed to make no difference in my environment.

To make it quick - just apply the supplied patch (processEffect.js.patch) to the formentioned processEffect.js file - I got rid of 'with' and 'eval' evils and seems to work :)

Enjoy!
                  
> rich:effect name does not properly create the JS function to be called
> ----------------------------------------------------------------------
>
>                 Key: RF-8608
>                 URL: https://issues.jboss.org/browse/RF-8608
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: component-misc, regression
>    Affects Versions: 3.3.3.Final
>            Reporter: Tomas Cerny
>             Fix For: 3.Future
>
>         Attachments: processEffect.js.patch, richFacesRegister.xhtml
>
>
> rich:effect name does not properly create the JS function..
> Consider your documentation example:
> <!--  invoking by JavaScript -->
> <div id="contentDiv">...</div>
> <input type="button" onclick="hideDiv({duration:0.7})" value="Hide" />
> <input type="button" onclick="showDiv()" value="Show" />
> <rich:effect  name="hideDiv"  for="contentDiv" type="Fade" />
> <rich:effect  name="showDiv"  for="contentDiv" type="Appear" />
> it worked on the older version but in 3.3.3 so I must downgrade :|
> This is my browser complaint:
> Error: Effect[A.type] is not a constructor
> Source File: http://localhost/a4j/g/3_3_3.Final/org/richfaces/ui.pack.js
> Line: 15201

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira