[richfaces-issues] [JBoss JIRA] (RF-12167) rich:extendedDatatable - onbeforeselectionchange is wrongly evaluated

Brian Leathem (JIRA) jira-events at lists.jboss.org
Mon May 7 12:28:18 EDT 2012


     [ https://issues.jboss.org/browse/RF-12167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Leathem resolved RF-12167.
--------------------------------

    Resolution: Done


Removed the extra "=" from the comparison to false

Benoit - thanks for reporting this issue, along with a suggested fix.  In the future, feel free to submit a pull request and get proper credit for your fixes!

https://community.jboss.org/wiki/ContributorGettingStartedGuide
                
> rich:extendedDatatable - onbeforeselectionchange is wrongly evaluated
> ---------------------------------------------------------------------
>
>                 Key: RF-12167
>                 URL: https://issues.jboss.org/browse/RF-12167
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: component-tables
>    Affects Versions: 4.0.0.Final
>            Reporter: Benoit VI
>            Assignee: Brian Leathem
>            Priority: Trivial
>             Fix For: 4.2.2.Final
>
>
> I noticed a typo error in onbeforeselectionchange javascript method : 
> There is two "=" instead of one in the second expression, and so it's always false !
> onbeforeselectionchange: function (event) {
>    return !this.options.onbeforeselectionchange || this.options.onbeforeselectionchange.call(this.element, event) !={color:red}={color} false;}
> The consequence is that it is impossible to use the onbeforeselectionchange attribute to eventually avoid selection change in certain cases (for instance to prevent the selection change when you click on a radio in the table).
> Thanks by advance for fixing this error.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the richfaces-issues mailing list