[richfaces-issues] [JBoss JIRA] (RF-13346) orderingList - maxListHeight & minListHeight need to have set units along with number to work

Brian Leathem (JIRA) jira-events at lists.jboss.org
Fri Nov 15 02:03:05 EST 2013


    [ https://issues.jboss.org/browse/RF-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923853#comment-12923853 ] 

Brian Leathem commented on RF-13346:
------------------------------------

While in [#75](https://github.com/richwidgets/richwidgets/issues/75#issuecomment-27821682) we agreed to follow the CSS behaviour and have:

# Integer values default to px units
# String values require units

However, as [~michpetrov] pointed out, all facelet attribute values are strings, and so the unit is always required.  While I don't advocate changing the RichWidget behaviour, I do feel we can safely add units in either the js bridge, or in the Renderer.  I suspect it is most _clean_ to intercept the option in the bridge and add the units if they are missing.
                
> orderingList - maxListHeight & minListHeight need to have set units along with number to work
> ---------------------------------------------------------------------------------------------
>
>                 Key: RF-13346
>                 URL: https://issues.jboss.org/browse/RF-13346
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: component-selects
>    Affects Versions: 5.0.0.Alpha2
>            Reporter: Jiří Štefek
>
> {{pickList}} attributes:
> * {{minListHeight}} and {{maxListHeight}}
> need to have set units along with the number value (e.g. 200px) in order to work correctly.
> In RF4 and in RichWidgets, these attributes can be left without units.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira



More information about the richfaces-issues mailing list