[richfaces-issues] [JBoss JIRA] (RF-13352) Introduce @Category(FailingOnFirefox.class) to pom.xml

Lukáš Fryč (JIRA) jira-events at lists.jboss.org
Tue Nov 19 11:44:06 EST 2013


    [ https://issues.jboss.org/browse/RF-13352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924998#comment-12924998 ] 

Lukáš Fryč commented on RF-13352:
---------------------------------

Lukas, few implementation notes:

<groups> and <exlucededGroups> is used to match what categories we want to run:
http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#groups
(note that <groups> should be rather named categories, but <groups> settings drives both, TestNG and JUnit tests, that's why maven-surefire-plugin follows TestNG naming conventions)


The idea is that if you turn on profile, it can append boolean conditions as the suffix of <groups> selector.

But I found that there is specific impl detail, which is not evident from first sight.
During prototyping I have used <groups> together with <excludedGroups>, but platform-specific configuration (e.g.  affects <groups>. That's why {{${testCategory.excluded.browser}}} needs to be setup as:

{code}
<testCategory.excluded.browser>AND NOT category.FailingFirefox</testCategory.excluded.browser>
{code}

You can use my prototype as a reference impl:
https://github.com/lfryc/surefire-and-junit-categories/blob/master/pom.xml#L175

                
> Introduce @Category(FailingOnFirefox.class) to pom.xml
> ------------------------------------------------------
>
>                 Key: RF-13352
>                 URL: https://issues.jboss.org/browse/RF-13352
>             Project: RichFaces
>          Issue Type: Enhancement
>      Security Level: Public(Everyone can see) 
>          Components: tests - functional 
>            Reporter: Lukáš Macko
>            Assignee: Lukáš Macko
>             Fix For: 5.0.0.Alpha2
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> Creating test for the chart component, I came across an issues that one test is running in Chrome and PhantomJS and it is failing on Firefox. As [~lfryc] suggested in the [comment | https://issues.jboss.org/browse/RF-13331?focusedCommentId=12923949&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12923949], I've annotated it with FailingOnFirefox. ATM it has no effect concerning tests.
> It might be useful to add this category to rf/pom.xml configuration to exclude FailingOnFirefox test when tests run on firefox. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira



More information about the richfaces-issues mailing list