[richfaces-issues] [JBoss JIRA] (RF-13371) Refactored Push destroy logic is too aggresive and causes ProgressBar to fail

[Lukáš Fryč (JIRA)]

    [ https://issues.jboss.org/browse/RF-13371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925929#comment-12925929 ] 

Lukáš Fryč commented on RF-13371:
---------------------------------

I have put a breakpoint into debugger and I can't see this component destroyed more than once or any other issues with the logic.

But I will double-check and make sure that the code is properly documented as it's not obvious.
                
> Refactored Push destroy logic is too aggresive and causes ProgressBar to fail
> -----------------------------------------------------------------------------
>
>                 Key: RF-13371
>                 URL: https://issues.jboss.org/browse/RF-13371
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>            Reporter: Lukáš Fryč
>            Assignee: Lukáš Fryč
>            Priority: Critical
>             Fix For: 5.0.0.Alpha2
>
>
> From RF-13359:
> {quote}
> It took a while, but I isolated the single offending line:
> https://github.com/richfaces/richfaces/blob/master/framework/src/main/resources/META-INF/resources/org.richfaces/push.js#L259
> {code}
>       $(document).on('cleanDom.RICH', function(event, ui) {
>         if ($.contains(ui.target, widget.element)) {
>           widget._destroy();
>         }
>       });
> {code}
> [~lfryc] It's not clear to me what you are trying to achieve here, but the end result seems to be that the destroy call is too aggressive.  Can you re-visit this please?
> {panel:title=Note:|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1|bgColor=#FFFFCE}
> The isolation was difficult, as the file in question should have nothing to do with the progressBar component.  Hence why the effect was observed only had an effect when included via resource packaging.
> {panel}
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira