[richfaces-issues] [JBoss JIRA] (RF-13233) Support attribute mapping for cdk:scriptOption

Brian Leathem (JIRA) jira-events at lists.jboss.org
Tue Oct 1 19:50:02 EDT 2013


    [ https://issues.jboss.org/browse/RF-13233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12808747#comment-12808747 ] 

Brian Leathem commented on RF-13233:
------------------------------------

The change required to the CDK to enable this feature is rather innocuous.  The _AddAttributesToScriptHashStatement_ class uses the _PassThrough_ to parse and hold the attribute names, which already has support for the "html" attribute name, and the "component" attribute name.  In the current implementation they are just set to the same value.  As such, introducing a split operation on the ":" character, and then falling back to setting the attribute names to be the same when no split is performed will leave the change idempotent for all existing use cases.

However, to make this work a change is required in the RenderkitUtils#addToScriptHash method, where the componentAttributeName is used instead of the htmlAttributeName.  This has worked fine until now as the values have been the same for all scriptOptions.  The change introduced to the CDK in this issue however allows for them to be different, and so the correct attribute name has to be used.
                
> Support attribute mapping for cdk:scriptOption
> ----------------------------------------------
>
>                 Key: RF-13233
>                 URL: https://issues.jboss.org/browse/RF-13233
>             Project: RichFaces
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: cdk
>            Reporter: Brian Leathem
>            Assignee: Brian Leathem
>             Fix For: cdk-4.5.0.Alpha2
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> The syntax for cdk:passThrough attributes supports attribute mapping:
> {code}
> cdk:passThrough="onclick:onlistclick ..."
> {code}
> It would be nice if the cdk:scriptOption supported similar attribute mapping, as in:
> {code}
> <cdk:scriptOption wrapper="eventHandler" attributes="change:onchange ..." />
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the richfaces-issues mailing list