[richfaces-issues] [JBoss JIRA] (RF-12802) Move page fragments from repository qa to richfaces5

Juraj Húska (JIRA) jira-events at lists.jboss.org
Fri Oct 4 05:19:03 EDT 2013


    [ https://issues.jboss.org/browse/RF-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12809354#comment-12809354 ] 

Juraj Húska commented on RF-12802:
----------------------------------

Couple of additional refactorings, we have discussed offline:

* Create interface for method {{advance()}} - 
{code}
 AdvancedInteractions<T> {
  T advanced();
}
{code} 

We can document the method more easily - the fragment will implement that interface

* provide a way to set JS strategy in {{arquillian.xml}} - e.g. 
{code:xml}
<extension name="richfacesPageFragments"><property name="controlStrategy">interactive</property> 
{code}

See ARQGRA-325 comments as well.

* waiting API - put {{withTimeout}} right to the wrapper, so the public API methods do not have call for the actual timeout value
* rename the parameter for setting of the timeout from _timeout_ to something which shows in what time unit it is - e.g. miliseconds
* move fields which hold timeout value to the {{AdvancedInteraction}} classes
* use miliseconds in waiting API instead of seconds as we found them to be more used accros tests
* review exception throwing - throw them where it is necessary, make the method no operation where it is not necessary
                
> Move page fragments from repository qa to richfaces5
> ----------------------------------------------------
>
>                 Key: RF-12802
>                 URL: https://issues.jboss.org/browse/RF-12802
>             Project: RichFaces
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>          Components: build/distribution
>    Affects Versions: 5.0.0.Alpha1
>            Reporter: Pavol Pitonak
>            Assignee: Brian Leathem
>             Fix For: 5.0.0.Alpha2
>
>
> As discussed on community meeting on Feb 12, we should move page fragments for RichFaces components to richfaces5 repository so that they are distributed with framework.
> We should find out how to prepare them so that they are easy to use for community members. RichFaces QE/dev need to test internals of components, community members will probably test only high-level functionality of components. One possible solution would be to create package "internal" in which there would be page fragments extending those from "public" package. QE team would then use "internal" implementations.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira



More information about the richfaces-issues mailing list