[richfaces-issues] [JBoss JIRA] (RF-13244) StyleProps and StyleClassProps should be merged to one interface

Brian Leathem (JIRA) jira-events at lists.jboss.org
Wed Oct 9 12:52:02 EDT 2013


    [ https://issues.jboss.org/browse/RF-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12812819#comment-12812819 ] 

Brian Leathem commented on RF-13244:
------------------------------------

[AbstractNotify|https://github.com/richfaces/richfaces/blob/master/framework/src/main/java/org/richfaces/ui/message/notify/AbstractNotify.java#L52] implements _StyleClassProps_ but not _StyleProps_

[AbstractCollapsibleSubTable|https://github.com/richfaces/richfaces/blob/master/framework/src/main/java/org/richfaces/ui/iteration/collapsibleSubTable/AbstractCollapsibleSubTable.java#L54] implements _StyleProps_ but not _StyleClassProps_.

When we defined attributes via xml, we were limited to having two distinct xml files to cover these attributes (while staying DRY).  Now that we have made the move to interfaces, we can define a thrid interface that inherits from both _StyleProps_ and _StyleClassProps_, and use this derived class in the 99% of use cases where both classes are present.

                
> StyleProps and StyleClassProps should be merged to one interface
> ----------------------------------------------------------------
>
>                 Key: RF-13244
>                 URL: https://issues.jboss.org/browse/RF-13244
>             Project: RichFaces
>          Issue Type: Enhancement
>      Security Level: Public(Everyone can see) 
>          Components: component
>    Affects Versions: 5.0.0.Alpha2
>            Reporter: Lukáš Fryč
>
> It doesn't make sense to have several style-realted interface since style and styleClass appears togetger.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira



More information about the richfaces-issues mailing list