[richfaces-issues] [JBoss JIRA] (RF-13276) Optimized resources should be generated into generated-resources

Brian Leathem (JIRA) jira-events at lists.jboss.org
Mon Oct 21 13:09:01 EDT 2013


    [ https://issues.jboss.org/browse/RF-13276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12823694#comment-12823694 ] 

Brian Leathem commented on RF-13276:
------------------------------------

Ideally we would generate the resources in the _generate-resources_ phase.  And copy them in the _process-resources_.  However we cannot generate the optimized resources until after the _GenerateResourcesMain_ class has been compiled.

To resolve this chicken/egg problem, I have split the _build-helper-maven-plugin_ execution into 2 parts.  The first continues to copy all non-resources sources in the _process-resources_ phase, and the second copies the resource sources in the _process-classes_ phase.  Not ideal, but it works.

Note: this solution requires the maven plugin execution order to be deterministic, as we have 2 plugins executing in the same phase.  This is expected to be true for maven >= 3.0.3 (MNG-2258).  If however the plugin execution does turn out to be none-deterministic (due to some outstanding bug) we can move the resource optimisation execution to a later maven phase.
                
> Optimized resources should be generated into generated-resources
> ----------------------------------------------------------------
>
>                 Key: RF-13276
>                 URL: https://issues.jboss.org/browse/RF-13276
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: resource handling
>    Affects Versions: 5.0.0.Alpha1
>            Reporter: Brian Leathem
>            Assignee: Brian Leathem
>             Fix For: 5.0.0.Alpha2
>
>   Original Estimate: 45 minutes
>  Remaining Estimate: 45 minutes
>
> The execution of org.richfaces.resource.optimizer.GenerateResourcesMain places the generated resources directly into the _target/classes_ folder.  Rather, the generated resources should be placed into _target/generated-resources_.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the richfaces-issues mailing list