[richfaces-issues] [JBoss JIRA] (RF-13167) disabled dropDownMenu is missing styleClass

[Brian Leathem (JIRA)]

    [ https://issues.jboss.org/browse/RF-13167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801672#comment-12801672 ] 

Brian Leathem commented on RF-13167:
------------------------------------

[~christoph_w] I agree with your assessment, and you have identified the correct place for a fix.  Would you like to formulate this as a github pull request?

https://community.jboss.org/wiki/GuideToUsePullRequestsWithGitHubAndJIRA

(don't forget to sign the CLA: https://cla.jboss.org/)
                
> disabled dropDownMenu is missing styleClass
> -------------------------------------------
>
>                 Key: RF-13167
>                 URL: https://issues.jboss.org/browse/RF-13167
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: component-menu
>    Affects Versions: 4.3.3
>            Reporter: Christoph W.
>   Original Estimate: 30 minutes
>  Remaining Estimate: 30 minutes
>
> We use rich:dropDownMenu with attributes disabled and styleClass. But when disabled is false then styleClass is not applied. Using classes for styling via CSS is a must, also for disabled components.
> Comment from attribute styleClass: ??"Space-separated list of CSS style class(es) to be applied when this element is rendered."??
> Also a disabled component may be rendered (otherwise styling wont matter).
> It is easy to fix. How to:
> DropDownMenuRenderer.doEncodeEnd(...) contains following line:
> {{String value = "rf-ddm-lbl " + convertToString((isDisabled ? "rf-ddm-dis" : ("rf-ddm-unsel " + styleClass))) + " ";}}
> If component is disabled styleClass must be added also.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira