[richfaces-issues] [JBoss JIRA] (RF-13172) rich:toolbarGroup location="right" doesn't work if toolbarGroup location="left" contains not rendered values

[Brian Leathem (JIRA)]

    [ https://issues.jboss.org/browse/RF-13172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802499#comment-12802499 ] 

Brian Leathem commented on RF-13172:
------------------------------------

The ToolbarGroup Renderer uses the rendered children when rendering:
https://github.com/richfaces/richfaces/blob/master/framework/src/main/java/org/richfaces/ui/menu/toolbar/ToolbarGroupRenderer.java#L48

but the ToolBar Renderer queries the ToolbarGroup for it's size including all children:
https://github.com/richfaces/richfaces/blob/master/framework/src/main/java/org/richfaces/ui/menu/toolbar/ToolbarRendererBase.java#L109

A possible fix would involve changing the ToolBar Renderer to cast the component to a ToolbarGroup (after the instanceof check) and call the getRenderedChildren() method instead of the children() method to get the child count.
                
> rich:toolbarGroup location="right" doesn't work if toolbarGroup location="left" contains not rendered values
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: RF-13172
>                 URL: https://issues.jboss.org/browse/RF-13172
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: component-menu
>    Affects Versions: 4.3.3
>            Reporter: Sergey Zubarev
>
> {code}
> <rich:toolbar itemSeparator="line" id="repairWorkToolbar">
>   <rich:toolbarGroup>
>     <a4j:commandLink value="btn1"/>
>     <a4j:commandLink value="btn2"/>
>     <a4j:commandLink value="btn3" *rendered="false"*/>
>   </rich:toolbarGroup>
>   <rich:toolbarGroup location="right">
>     <a4j:commandLink value="btn_right"/>
>   </rich:toolbarGroup>
> ...
> {code}
> In this case location="right" doesn't work : it displayed left. When I remove rendered="false" from btn3 all works fine.
> Html debug shows, that code produced one extra element in colgroup tag when using rendered="false".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira