[richfaces-issues] [JBoss JIRA] (RF-11103) org.richfaces.skin = plain causes java.lang.IllegalArgumentException: Width (2000) and height (0) cannot be <= 0

[Brian Leathem (JIRA)]

    [ https://issues.jboss.org/browse/RF-11103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803334#comment-12803334 ] 

Brian Leathem commented on RF-11103:
------------------------------------

Changing the skin background image reference as follows also resolves this immediate problem:

{code}
background-image: "url(#{resource['org.richfaces.images:buttonBackgroundImage.png']})";
{code}
to
{code}
background-image: "#{empty richSkin.generalSizeFont ? 'none' : 'url('.concat(resource['org.richfaces.images:buttonBackgroundImage.png']).concat(')')}";
{code}

----

I think this problem can be broken into 2 pieces:
# Fix the broken plain skin by fixing the broken background-image references
# Prevent the control skinning resources from being served

1) can be solved with a fix similar to the one at the top of this comment, or we can introduce an EL function to clean it up.

2) can be solved by not serving the control skinning resources when *both* _enableControlSkinning_ and _enableControlSkinningClasses_ are false.

Both of these fixes are out of scope for RF 4.3.4.  We will resolve this issue in RichFaces 5, and backport it to a future 4.3.x release as appropriate.
                
> org.richfaces.skin = plain causes java.lang.IllegalArgumentException: Width (2000) and height (0) cannot be <= 0
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: RF-11103
>                 URL: https://issues.jboss.org/browse/RF-11103
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: skinning
>            Reporter: u j
>            Priority: Minor
>              Labels: needs-qe
>             Fix For: 4.3.4, 5.0.0.Alpha2
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> I tried
> {code}
> <context-param>
>         <param-name>org.richfaces.skin</param-name>
>         <param-value>plain</param-value>
>     </context-param>
> {code}
>  
> and the skinning seems to be disabled, but I get
> {code}
> 14:44:21,584 ERROR [org.apache.catalina.core.ContainerBase.[jboss.web].[localhost].[/myapp].[Faces Servlet]] Servlet.service() para servlet Faces Servlet lanzó excepción: java.lang.IllegalArgumentException: Width (2000) and height (0) cannot be <= 0
>     at java.awt.image.DirectColorModel.createCompatibleWritableRaster(DirectColorModel.java:999) [:1.6.0_24]
>     at java.awt.image.BufferedImage.<init>(BufferedImage.java:321) [:1.6.0_24]
>     at org.richfaces.resource.ImageType.createARGBImage(ImageType.java:103) [:4.0.0-SNAPSHOT]
>     at org.richfaces.resource.ImageType.access$200(ImageType.java:34) [:4.0.0-SNAPSHOT]
>     at org.richfaces.resource.ImageType$2.createImage(ImageType.java:44) [:4.0.0-SNAPSHOT]
>     at org.richfaces.resource.ImageType.createImage(ImageType.java:118) [:4.0.0-SNAPSHOT]
>     at org.richfaces.resource.Java2DUserResourceWrapperImpl.paintAndWrite(Java2DUserResourceWrapperImpl.java:155) [:4.0.0-SNAPSHOT]
>     at org.richfaces.resource.Java2DUserResourceWrapperImpl.getInputStream(Java2DUserResourceWrapperImpl.java:65) [:4.0.0-SNAPSHOT]
>     at org.richfaces.resource.CachedResourceImpl.initialize(CachedResourceImpl.java:178) [:4.0.0-SNAPSHOT]
>     at org.richfaces.resource.ResourceHandlerImpl.handleResourceRequest(ResourceHandlerImpl.java:171) [:4.0.0-SNAPSHOT]
>     at javax.faces.webapp.FacesServlet.service(FacesServlet.java:407) [:2.1.1-FCS]
> 14:45:38,493 ERROR [org.apache.catalina.core.ContainerBase.[jboss.web].[localhost].[/myapp].[Faces Servlet]] Servlet.service() para servlet Faces Servlet lanzó excepción: java.lang.IllegalArgumentException: Width (1) and height (0) cannot be <= 0
>     at java.awt.image.DirectColorModel.createCompatibleWritableRaster(DirectColorModel.java:999) [:1.6.0_24]
>     at java.awt.image.BufferedImage.<init>(BufferedImage.java:321) [:1.6.0_24]
>     at org.richfaces.resource.ImageType.createARGBImage(ImageType.java:103) [:4.0.0-SNAPSHOT]
>     at org.richfaces.resource.ImageType.access$200(ImageType.java:34) [:4.0.0-SNAPSHOT]
>     at org.richfaces.resource.ImageType$2.createImage(ImageType.java:44) [:4.0.0-SNAPSHOT]
>     at org.richfaces.resource.ImageType.createImage(ImageType.java:118) [:4.0.0-SNAPSHOT]
>     at org.richfaces.resource.Java2DUserResourceWrapperImpl.paintAndWrite(Java2DUserResourceWrapperImpl.java:155) [:4.0.0-SNAPSHOT]
>     at org.richfaces.resource.Java2DUserResourceWrapperImpl.getInputStream(Java2DUserResourceWrapperImpl.java:65) [:4.0.0-SNAPSHOT]
>     at org.richfaces.resource.CachedResourceImpl.initialize(CachedResourceImpl.java:178) [:4.0.0-SNAPSHOT]
>     at org.richfaces.resource.ResourceHandlerImpl.handleResourceRequest(ResourceHandlerImpl.java:171) [:4.0.0-SNAPSHOT]
>     at javax.faces.webapp.FacesServlet.service(FacesServlet.java:407) [:2.1.1-FCS]
>     at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:324) [:6.0.0.Final]
>     at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:242) [:6.0.0.Final]
>     at org.jboss.weld.servlet.ConversationPropagationFilter.doFilter(ConversationPropagationFilter.java:67) [:6.0.0.Final]
> {code}
> I found a note
> http://echelog.matzon.dk/logs/browse/richfaces/1306706400
> Thanks

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira