[richfaces-issues] [JBoss JIRA] (RF-13191) The RichFaces base deployment for integration tests incorrectly disables control skinning

[Brian Leathem (JIRA)]

     [ https://issues.jboss.org/browse/RF-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Leathem updated RF-13191:
-------------------------------

    Description: 
See: https://github.com/richfaces/richfaces/blob/master/build/build-resources/src/main/java/org/richfaces/deployment/Deployment.java#L95

Integration test environments should as closely as possible follow real environments.  Since this parameter can be over-ridden in an individual deployment (see below), I recommend we remove this configuration in the default deployment.

{code}
        deployment.webXml(new Function<WebAppDescriptor, WebAppDescriptor>() {
            public WebAppDescriptor apply(WebAppDescriptor descriptor) {

                descriptor.getOrCreateContextParam()
                        .paramName("org.richfaces.enableControlSkinning")
                        .paramValue("false");

                return descriptor;
            }
        });
{code} 

Note: after making this change, all tests will need to be run, and any tests that rely on this configuration will have to be adjusted to set the context-param on their individual deployment.

  was:
See: https://github.com/richfaces/richfaces/blob/master/build/build-resources/src/main/java/org/richfaces/deployment/Deployment.java#L95

Integration test environments should as closely as possible follow real environments.  Since this parameter can be over-ridden in an individual deployment (see below), I recommend we remove this configuration in the default deployment.

{code}
        deployment.webXml(new Function<WebAppDescriptor, WebAppDescriptor>() {
            public WebAppDescriptor apply(WebAppDescriptor input) {

                input.getOrCreateContextParam()
                        .paramName("org.richfaces.skin")
                        .paramValue("plain");

                return input;
            };
{code} 

Note: after making this change, all tests will need to be run, and any tests that rely on this configuration will have to be adjusted to set the context-param on their individual deployment.


    
> The RichFaces base deployment for integration tests incorrectly disables control skinning
> -----------------------------------------------------------------------------------------
>
>                 Key: RF-13191
>                 URL: https://issues.jboss.org/browse/RF-13191
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>            Reporter: Brian Leathem
>            Assignee: Brian Leathem
>             Fix For: 5.0.0.Alpha2
>
>   Original Estimate: 30 minutes
>  Remaining Estimate: 30 minutes
>
> See: https://github.com/richfaces/richfaces/blob/master/build/build-resources/src/main/java/org/richfaces/deployment/Deployment.java#L95
> Integration test environments should as closely as possible follow real environments.  Since this parameter can be over-ridden in an individual deployment (see below), I recommend we remove this configuration in the default deployment.
> {code}
>         deployment.webXml(new Function<WebAppDescriptor, WebAppDescriptor>() {
>             public WebAppDescriptor apply(WebAppDescriptor descriptor) {
>                 descriptor.getOrCreateContextParam()
>                         .paramName("org.richfaces.enableControlSkinning")
>                         .paramValue("false");
>                 return descriptor;
>             }
>         });
> {code} 
> Note: after making this change, all tests will need to be run, and any tests that rely on this configuration will have to be adjusted to set the context-param on their individual deployment.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira