[richfaces-issues] [JBoss JIRA] (RF-13537) Autocomplete: onbegin attribute igniored

Brian Leathem (JIRA) issues at jboss.org
Fri Feb 7 12:00:30 EST 2014


    [ https://issues.jboss.org/browse/RF-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12942691#comment-12942691 ] 

Brian Leathem commented on RF-13537:
------------------------------------

That's great, thanks for investigating [~alixey].  At first glance you patch looks good.  Please go ahead and issue a Pull Request.  (Don't forget to sign the [CLA|https://cla.jboss.org/index.seam] if you haven't previously done so)
                
> Autocomplete: onbegin attribute igniored
> ----------------------------------------
>
>                 Key: RF-13537
>                 URL: https://issues.jboss.org/browse/RF-13537
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 4.3.5
>            Reporter: alexey plotnikov
>
> "onbegin" attribute of rich:autocomplete is always ignored!
> I suggest next fix:
> In file Autocomplete.js:
> {code}
> var callAjax = function(event, callback) {
> ...
> this.isFirstAjax = false;
>         //caution: JSF submits inputs with empty names causing "WARNING: Parameters: Invalid chunk ignored." in Tomcat log
>         var params = {};
>         params[this.id + ".ajax"] = "1";
> rf.ajax(this.id, event, {parameters: params, error: ajaxError, complete:ajaxSuccess});
> }
> {code}
> for fixing, we must replace on
> {code}
> var callAjax = function(event, callback) {
> ...
> this.isFirstAjax = false;
>         //caution: JSF submits inputs with empty names causing "WARNING: Parameters: Invalid chunk ignored." in Tomcat log
>         var params = {};
>         params[this.id + ".ajax"] = "1";
> var parameters_extended = {parameters: params, error: ajaxError, complete:ajaxSuccess};
>         if (this.options.onbegin != undefined) {
>             parameters_extended.begin = this.options.onbegin;
>         }
>         rf.ajax(this.id, event, parameters_extended);
> }
> {code}
> I can create pull request if everything ok.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the richfaces-issues mailing list