[richfaces-issues] [JBoss JIRA] (RF-13538) Closeables.closeQuietly() removed in Guava 16.0, but still used in RF

Cody Lerum (JIRA) issues at jboss.org
Tue Feb 11 13:11:28 EST 2014


    [ https://issues.jboss.org/browse/RF-13538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12943567#comment-12943567 ] 

Cody Lerum commented on RF-13538:
---------------------------------

This was always an @Beta feature (http://docs.guava-libraries.googlecode.com/git-history/v13.0.1/javadoc/index.html) and probably shouldn't have been depended on.
                
> Closeables.closeQuietly() removed in Guava 16.0, but still used in RF
> ---------------------------------------------------------------------
>
>                 Key: RF-13538
>                 URL: https://issues.jboss.org/browse/RF-13538
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: core
>    Affects Versions: 5.0.0.Alpha3
>            Reporter: Juergen Zimmermann
>
> For instance in org.richfaces.resource.Java2DUserResourceWrapperImpl at line 73 is an invocation of Closeables.closeQuietly(...). However, this method is removed in Guava 16.0 which is now used in RF 5.0.0.Alpha3.
> javadoc of Guava 14.0 already mentioned:
> "Deprecated. Where possible, use the try-with-resources statement if using JDK7 or Closer on JDK6 to close one or more Closeable objects. This method is deprecated because it is easy to misuse and may swallow IO exceptions that really should be thrown and handled. See Guava issue 1118 for a more detailed explanation of the reasons for deprecation and see  Closing Resources for more information on the problems with closing Closeable objects and some of the preferred solutions for handling it correctly. This method is scheduled to be removed in Guava 16.0."
> Well, now the method is removed, but still invoked in RF 5.0.0.Alpha3.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the richfaces-issues mailing list