[richfaces-issues] [JBoss JIRA] (RF-12897) ExtendedPartialViewContextImpl swallows exceptions

[Brian Leathem (JIRA)]

    [ https://issues.jboss.org/browse/RF-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12944059#comment-12944059 ] 

Brian Leathem commented on RF-12897:
------------------------------------

[~lfryc] is this still an issue with your proposed EPVC rewrite?
                
> ExtendedPartialViewContextImpl swallows exceptions
> --------------------------------------------------
>
>                 Key: RF-12897
>                 URL: https://issues.jboss.org/browse/RF-12897
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: core
>    Affects Versions: 4.2.2.Final
>         Environment: Windows 7, JDK 1.6
>            Reporter: Cristian Cerb
>            Assignee: Lukáš Fryč
>              Labels: richfaces
>             Fix For: 5-Tracking
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Method public VisitResult visit(VisitContext context, UIComponent target) of class ExtendedPartialViewContextImpl swallows exceptions. I think exceptions should be wrapped inside a FaceException and propagated. This class  http://java.net/projects/mojarra/sources/svn/content/trunk/jsf-ri/src/main/java/com/sun/faces/context/PartialViewContextImpl.java seems to have served as a model for the RF one, but the RF class inadvertently chose to swallow exceptions instead of propagating them up. This causes unpredictable behaviour, such as system being stuck in the browser.
> I just found an older version of Sun's Mojarra where they had the same issue, but the newer versions seem to have fixed it. See this taken from jsf 2.1.4:
> {code}
>         public VisitResult visit(VisitContext context, UIComponent comp) {
>             try {
>                 if (curPhase == PhaseId.APPLY_REQUEST_VALUES) {
>                     // RELEASE_PENDING handle immediate request(s)
>                     // If the user requested an immediate request
>                     // Make sure to set the immediate flag here.
>                     comp.processDecodes(ctx);
>                 } else if (curPhase == PhaseId.PROCESS_VALIDATIONS) {
>                     comp.processValidators(ctx);
>                 } else if (curPhase == PhaseId.UPDATE_MODEL_VALUES) {
>                     comp.processUpdates(ctx);
>                 } else if (curPhase == PhaseId.RENDER_RESPONSE) {
>                     PartialResponseWriter writer = ctx.getPartialViewContext().getPartialResponseWriter();
>                     writer.startUpdate(comp.getClientId(ctx));
>                     try {
>                         // do the default behavior...
>                         comp.encodeAll(ctx);
>                     }
>                     catch (Exception ce) {
>                         if (LOGGER.isLoggable(Level.SEVERE)) {
>                             LOGGER.severe(ce.toString());
>                         }
>                         if (LOGGER.isLoggable(Level.FINE)) {
>                             LOGGER.log(Level.FINE,
>                             ce.toString(),
>                             ce);
>                         }
>                     }
>                     writer.endUpdate();
>                 }
>                 else {
>                     throw new IllegalStateException("I18N: Unexpected " +
>                                                     "PhaseId passed to " +
>                                               " PhaseAwareContextCallback: " +
>                                                     curPhase.toString());
>                 }
>             }
>             catch (IOException ex) {
>                 ex.printStackTrace();
>             }
>             // Once we visit a component, there is no need to visit
>             // its children, since processDecodes/Validators/Updates and
>             // encodeAll() already traverse the subtree.  We return
>             // VisitResult.REJECT to supress the subtree visit.
>             return VisitResult.REJECT;
>         }
>     }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira