[richfaces-issues] [JBoss JIRA] (RF-13690) DataTable in uiRepeat - scrolling in table makes columns unsorted again

[Brian Leathem (JIRA)]

    [ https://issues.jboss.org/browse/RF-13690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984931#comment-12984931 ] 

Brian Leathem commented on RF-13690:
------------------------------------

I reverted the change introduced by [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152] and rebuilt mojarra 2.2.6.  Replacing the jsf-impl jar with this new one in WildFly 8.1 resolved the problem, so I can confirm this issue is caused by [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152].

The relevant change in [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152] is:
{code}
----------------------------
Index: jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java
===================================================================
--- jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java	(revision 12814)
+++ jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java	(working copy)
@@ -787,7 +787,9 @@
         // Just need to check whether there are any ids under this
         // subtree.  Make sure row index is cleared out since
         // getSubtreeIdsToVisit() needs our row-less client id.
-        setIndex(context.getFacesContext(), -1);
+        if (requiresRowIteration(context)) {
+            setIndex(context.getFacesContext(), -1);
+        }
         Collection<String> idsToVisit = context.getSubtreeIdsToVisit(this);
         assert(idsToVisit != null);
{code}

and it's meant to address: 
{quote}
{{<ui:repeat>}}'s value attribute gets evaluated during each and every ajax call, even when {{<ui:repeat>}} is outside the render area
{quote}

> DataTable in uiRepeat - scrolling in table makes columns unsorted again
> -----------------------------------------------------------------------
>
>                 Key: RF-13690
>                 URL: https://issues.jboss.org/browse/RF-13690
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: component-tables
>    Affects Versions: 4.5.0.Alpha3
>         Environment: WildFly 8.1.
>            Reporter: Juraj Húska
>            Assignee: Brian Leathem
>              Labels: regression
>             Fix For: 4.5.0.Alpha3
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> When {{DataTable}} is nested in {{uiRepeat}}, then scrolling over the table with {{dataScroller}} makes sorting according to some column broken - the columns are unsorted.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)