[richfaces-issues] [JBoss JIRA] (RF-11093) UIDataAdaptor context variable backup broken (reentrance problem)

[Yannick Valot (JIRA)]

    [ https://issues.jboss.org/browse/RF-11093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985036#comment-12985036 ] 

Yannick Valot commented on RF-11093:
------------------------------------

Alas, this issue is quite old and I do not have a reproducer available

Maybe this could do the trick :

1) In the repeat, include a commandLink and bind it to an action (action="#{someBean.someAction}")
2) In "someAction" :
2a) visit the componentTree by calling FacesContext.getCurrentInstance().getViewRoot().visitTree(...) (the callback does not actually need to do anything useful)
2b) After the visit, read the attribute value, without the patch, it will be null or contain some old value not related to the current row.

> UIDataAdaptor context variable backup broken (reentrance problem)
> -----------------------------------------------------------------
>
>                 Key: RF-11093
>                 URL: https://issues.jboss.org/browse/RF-11093
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: component-tables
>    Affects Versions: 4.0.0.Final
>         Environment:  Windows XP, Java 6, Tomcat 6.0.24, Mojarra 2.0.2.
>            Reporter: Yannick Valot
>            Assignee: Yannick Valot
>             Fix For: 4.5.0.Alpha3
>
>         Attachments: UIDataAdaptor.java.patch
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> I am encountering a reentrance problem with org.richfaces.component.UIDataAdaptor (using it as a dataTable).
> I need to perform a visit of the component tree while executing an action on a command link in one row of the same table.
> {code}
> <rich:dataTable value="#{listOfItems}" var="myItem" >
> 	... some stuff here ...
> 		<commandLink here>
> 	... some stuff here ...
> </rich:dataTable>
> {code}
> After the action on the command link has visited the component tree, myItem is no longer available in context.
> When the UIDataAdaptor sets or resets the "myItem" context variable, it backs up any previous value by calling captureOrigValue(FacesContext), and later restores it by calling restoreOrigValue(FacesContext), but it looks as if the visit backs the variable up twice (in a nested fashion), and it erases myItem between the two backups :
> - backup variable (old value is correctly backed up) (in visitTree(VisitContext visitContext, VisitCallback callback))
> - erase variable (setRowKey(facesContext, null) in same function)
> - erase variable (doVisitChildren(VisitContext context, boolean visitRows))
> - erase variable (visitTree(VisitContext visitContext, VisitCallback callback))
> - backup variable (erases backed up value) (walk(FacesContext faces, DataVisitor visitor, Object argument))
> - ...
> - restore value  (restores null) (walk(FacesContext faces, DataVisitor visitor, Object argument))
> - restore value  (restores null) (in visitTree(VisitContext visitContext, VisitCallback callback))
> etc.
> The problem can be solved by *stacking* backed up variables, instead of storing them in a simple attribute, to allow for any kind of reentrance.
> (I do not say that this is the best possible patch, but it has solved the problem for me).



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)