[richfaces-issues] [JBoss JIRA] (RF-13582) Revert the core package re-factoring

[Jiří Štefek (JIRA)]

    [ https://issues.jboss.org/browse/RF-13582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977037#comment-12977037 ] 

Jiří Štefek edited comment on RF-13582 at 6/19/14 6:48 AM:
-----------------------------------------------------------

I have created a branch in qa repo for this. [This commit|https://github.com/richfaces/richfaces-qa/commit/5eab3f39145cf1bd65e58a1798c39b967b19d5d2] adds the RF 4.5 jars to Metamer and make it compilable, could you, please, check if I didn't something wrong? As you can see in the commit, there are just changes in rich components (not in core components).

I've also run all tests for a4j components from this branch ([verified with this job|https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/richfaces-x.y-metamer-parametrized-test-runner-win/375/], ignore the status JS API tests (different call of JS API function in RF 4.3 and 4.5 {{RichFaces.$}} X {{RichFaces.component}})) + manually verified {{queue}} and {{attachedQueue}} components (there are no WebDriver tests for them). From these results I can confirm that all a4j components works correctly in 4.3 Metamer with 4.5 components.


was (Author: jstefek):
I have created a branch in qa repo for this. [This commit|https://github.com/richfaces/richfaces-qa/commit/5eab3f39145cf1bd65e58a1798c39b967b19d5d2] adds the RF 4.5 jars to Metamer and make it compilable, could you, please, check if I didn't something wrong? As you can see in the commit, there are just changes in rich components.

I've also run all tests for a4j components from this branch ([verified with this job|https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/richfaces-x.y-metamer-parametrized-test-runner-win/375/], ignore the status JS API tests (different call of JS API function in RF 4.3 and 4.5 {{RichFaces.$}} X {{RichFaces.component}})) + manually verified {{queue}} and {{attachedQueue}} components (there are no WebDriver tests for them). From these results I can confirm that all a4j components works correctly.

> Revert the core package re-factoring
> ------------------------------------
>
>                 Key: RF-13582
>                 URL: https://issues.jboss.org/browse/RF-13582
>             Project: RichFaces
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 4.5.0.Alpha3
>            Reporter: Brian Leathem
>            Assignee: Michal Petrov
>              Labels: needs-qe
>             Fix For: 4.5.0.Alpha3
>
>   Original Estimate: 3 hours
>  Remaining Estimate: 3 hours
>
> To improve compatibility with RichFaces 4.3, the package re-factorings introduced should be reverted.  These include (but are not limited to):
> * .servlet (PushServlet, ResourceServlet)
> * .push.cdi (@PUsh)
> * .push. (TopicContext)
> * FileUploadException
> A good test for this would be to compile and run the RichFaces 4.3 showcase and metamer samples against RichFaces 4.5 looking for failures.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)