[richfaces-issues] [JBoss JIRA] (RF-13665) RichFaces 4.5 should fail fast when used with un-pached Mojarra

[Brian Leathem (JIRA)]

    [ https://issues.jboss.org/browse/RF-13665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977850#comment-12977850 ] 

Brian Leathem edited comment on RF-13665 at 6/19/14 1:25 PM:
-------------------------------------------------------------

Nice catch!  I'd failed to account for X.Y.X-SNAPSHOT version numbers - this would have bit us fairly quickly I'm sure ;-)

I updated the version inspector to consider SNAPSHOT version classifiers, and updated the corresponding unit test.  Feel free to add any more cases to the unit test that you feel should be covered.

Also: we should check that the check works with MyFaces.  We expect deployment to succeed with all versions of MyFaces.


was (Author: bleathem):
Nice catch!  I'd failed to account for X.Y.X-SNAPSHOT version numbers - this would have bit us fairly quickly I'm sure ;-)

I updated the version inspector to consider SNAPSHOT version classifiers, and updated the corresponding unit test.  Feel free to add any more cases to the unit test that you feel should be covered.

> RichFaces 4.5 should fail fast when used with un-pached Mojarra
> ---------------------------------------------------------------
>
>                 Key: RF-13665
>                 URL: https://issues.jboss.org/browse/RF-13665
>             Project: RichFaces
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: core
>    Affects Versions: 4.5.0.Alpha3
>            Reporter: Juraj Húska
>            Assignee: Brian Leathem
>              Labels: needs-qe
>             Fix For: 4.5.0.Alpha3
>
>
> [~bleathem] wrote [in this comment|https://issues.jboss.org/browse/RF-13658?focusedCommentId=12975468&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12975468] for RF-13658:
> ??There is a Mojarra bug that breaks the new EPVC ([JAVASERVERFACES-3151|https://java.net/jira/browse/JAVASERVERFACES-3151]). This issue was patched in the mojarra impl that shipped with WildFly 8.0.0.Final, and in the Mojarra impl that shipped with EAP was also patched??
> ??We should have some code in place to fail fast if RichFaces 4.5 is used with an unpatched Mojarra. This can be achieved with reflection, looking for the method added in [JAVASERVERFACES-3151|https://java.net/jira/browse/JAVASERVERFACES-3151]??
> And we are not failing fast. I would say that when application is about to use unpached Mojarra, the fail fast would be a runtime exception during deployment ?
>  



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)