[richfaces-issues] [JBoss JIRA] (RF-13564) rich:pickList has unnecessary tabindex in div

[Brian Leathem (JIRA)]

    [ https://issues.jboss.org/browse/RF-13564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12950374#comment-12950374 ] 

Brian Leathem commented on RF-13564:
------------------------------------

The _tabindex_ attribute is present to [make the element focusable|http://snook.ca/archives/accessibility_and_usability/elements_focusable_with_tabindex].  This is in accordance with [WAI-ARIA|http://www.w3.org/WAI/PF/aria-practices/#focus_tabindex] and [HTML 5|http://www.w3.org/html/wg/drafts/html/master/single-page.html#attr-tabindex] specifications.  Removing the _tabindex_ attribute would be a step backwards.

The outline you see is rather a styling issue, and can be corrected with the CSS rule:
{code}
outline: none !important;
{code}

If you would like to file a pull request with this fix, that would be much appreciated.  Just be sure to [sign the CLA|https://cla.jboss.org/].

Note: you can use this as a temporary workaround in your project.
                
> rich:pickList has unnecessary tabindex in div
> ---------------------------------------------
>
>                 Key: RF-13564
>                 URL: https://issues.jboss.org/browse/RF-13564
>             Project: RichFaces
>          Issue Type: Enhancement
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 4.3.5
>            Reporter: alexey plotnikov
>             Fix For: 4.3.6
>
>
> Hi all, i use rich:pickList and i was amazing. If we press left button on a mouse(don't release left button) on rich:pickList we'll see rectangle. You can check it [here|http://showcase.richfaces.org/richfaces/component-sample.jsf?demo=pickList&skin=blueSky].
> I found a solution:
> in file template "picklist.template.xml"
> {code}
> ...
> <div id="#{clientId}" tabindex="-1" class="#{concatClasses('rf-pick', component.attributes['styleClass'], disabled ? component.attributes['disabledClass'] : '')}" style="#{component.attributes['style']}"
>              cdk:passThrough="onclick:onclick ondblclick:ondblclick onmousedown:onmousedown onmouseup:onmouseup onmouseover:onmouseover
>                               onmousemove:onmousemove onmouseout:onmouseout onkeypress:onkeypress onkeydown:onkeydown onkeyup:onkeyup">
> ...
> {code}
> used tabindex attribue for DIV.
> Why?
> DIV elements are not compatible with tabindex ([see the HTML 4.01 spec|http://www.w3.org/TR/html401/interact/forms.html#adef-tabindex]).
> I can create pull request :).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira