[richfaces-issues] [JBoss JIRA] (RF-13629) popupPanel - minWidth, minHeight, maxWidth, maxHeight are not ignored when autosize == true

Brian Leathem (JIRA) issues at jboss.org
Fri May 16 13:17:56 EDT 2014


    [ https://issues.jboss.org/browse/RF-13629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968518#comment-12968518 ] 

Brian Leathem commented on RF-13629:
------------------------------------

{quote}
When autosized == true, performance of moving the popupPanel on Firefox (29) is very bad. It is not a smooth transition at all, affecting usability a lot. It is also regression against 4.3.6.Final. - Chrome works just ok
{quote}

This works perfectly fine for me with Firefox 29 and Chrome 34 on my Ubuntu 14.04 installation.  Is there anything unique about your workstation that might give a performance problem?  Are you running in a VM for instance?

{quote}
when height or width is set to 0, then RF-10251 can not be reproduced anymore, however, another issue occurs - popupPanel is rendered with width as big as screen, and it is adjusted to the correct one, once it is moved (resembles RF-13616). - it is quite arguable whether this is a bug
{quote}

Setting height or width to 0 is nonsensical.  Not a use case we need to cover.

{quote}
IMHO width and height like attributes requires refactoring,
{quote}

This is hard to do given the lack of client-side tests for the popupPanel and the lack of comments in the code.  The current plan is to replace the client-side implementation with a standalone javascript implementation in RichFaces 5.  Until then we will have to be conservative in our patches of the javascript implementation.

{quote}
validation of the values user set to them, so for example it will not be possible to set width to 0. The VDL doc for some attributes (e.g. minHeight) is describing this, however, it does not check the values at all.
{quote}

Please file a new jira issue for this, we will consider addressing it in a future release.

> popupPanel - minWidth, minHeight, maxWidth, maxHeight are not ignored when autosize == true
> -------------------------------------------------------------------------------------------
>
>                 Key: RF-13629
>                 URL: https://issues.jboss.org/browse/RF-13629
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: component-output
>    Affects Versions: 4.3.7
>         Environment: Firefox
>            Reporter: Juraj Húska
>            Assignee: Brian Leathem
>            Priority: Critical
>              Labels: regression
>             Fix For: 4.5.0.Alpha3
>
>         Attachments: popupPanelGood.png, popupPanelWrong.png, sample.zip
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> In previous releases when attribute {{autosize == true}} attributes from $SUBJECT were ignored. In {{4.3.7.}}, they are not.
> When used together (does not really make sense IMHO, but maybe I am neglecting some use case), the popup width is not adjusted automatically.



--
This message was sent by Atlassian JIRA
(v6.2.3#6260)



More information about the richfaces-issues mailing list