[richfaces-issues] [JBoss JIRA] (RF-13629) popupPanel - minWidth, minHeight, maxWidth, maxHeight are not ignored when autosize == true

Juraj Húska (JIRA) issues at jboss.org
Mon May 19 05:14:57 EDT 2014


    [ https://issues.jboss.org/browse/RF-13629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968656#comment-12968656 ] 

Juraj Húska edited comment on RF-13629 at 5/19/14 5:13 AM:
-----------------------------------------------------------

The bad performance of {{popupPanel}} moving was introduced by this commit:
https://github.com/richfaces4/components/commit/aa2ab4c60520ec928787ad6d4be0702d280d6309

It is even worse when next commit is applied:
https://github.com/richfaces4/components/commit/b0eb8e4f7facb03e3e836f8293a0d1f1b7a2ca35

Firebug profiler tells that:
* function with biggest own time value: https://github.com/richfaces4/components/blob/master/output/ui/src/main/resources/META-INF/resources/org.richfaces/popupPanel.js#L111
* function with biggest time value: https://github.com/richfaces4/components/blob/master/output/ui/src/main/resources/META-INF/resources/org.richfaces/popupPanelBorders.js#L78

If you can tell me what I can test more, I will.



was (Author: jhuska):
The bad performance of {{popupPanel}} moving was introduced by this commit:
https://github.com/richfaces4/components/commit/aa2ab4c60520ec928787ad6d4be0702d280d6309

It is even worse when next commit is applied:
https://github.com/richfaces4/components/commit/b0eb8e4f7facb03e3e836f8293a0d1f1b7a2ca35

Firebug profiler tells that:
* function with biggest own time value: https://github.com/richfaces4/components/blob/master/output/ui/src/main/resources/META-INF/resources/org.richfaces/popupPanel.js#L111
* function with biggest time value: https://github.com/richfaces4/components/blob/master/output/ui/src/main/resources/META-INF/resources/org.richfaces/popupPanelBorders.js#L78

If you can tell me what I can do more, I will.


> popupPanel - minWidth, minHeight, maxWidth, maxHeight are not ignored when autosize == true
> -------------------------------------------------------------------------------------------
>
>                 Key: RF-13629
>                 URL: https://issues.jboss.org/browse/RF-13629
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: component-output
>    Affects Versions: 4.3.7
>         Environment: Firefox
>            Reporter: Juraj Húska
>            Assignee: Brian Leathem
>            Priority: Critical
>              Labels: regression
>             Fix For: 4.5.0.Alpha3
>
>         Attachments: popupPanelGood.png, popupPanelWrong.png, sample.zip
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> In previous releases when attribute {{autosize == true}} attributes from $SUBJECT were ignored. In {{4.3.7.}}, they are not.
> When used together (does not really make sense IMHO, but maybe I am neglecting some use case), the popup width is not adjusted automatically.



--
This message was sent by Atlassian JIRA
(v6.2.3#6260)



More information about the richfaces-issues mailing list