[richfaces-svn-commits] JBoss Rich Faces SVN: r6245 - trunk/ui/combobox/src/main/java/org/richfaces/renderkit.

[richfaces-svn-commits at lists.jboss.org]

Author: abelevich
Date: 2008-02-21 09:42:52 -0500 (Thu, 21 Feb 2008)
New Revision: 6245

Modified:
   trunk/ui/combobox/src/main/java/org/richfaces/renderkit/ComboBoxBaseRenderer.java
Log:
fix add values

Modified: trunk/ui/combobox/src/main/java/org/richfaces/renderkit/ComboBoxBaseRenderer.java
===================================================================
--- trunk/ui/combobox/src/main/java/org/richfaces/renderkit/ComboBoxBaseRenderer.java	2008-02-21 14:07:57 UTC (rev 6244)
+++ trunk/ui/combobox/src/main/java/org/richfaces/renderkit/ComboBoxBaseRenderer.java	2008-02-21 14:42:52 UTC (rev 6245)
@@ -84,7 +84,7 @@
 		Object suggestionValues = comboBox.getSuggestionValues();
 		ResponseWriter writer = context.getResponseWriter();
 		
-		List values = getValuesList();
+		List values = new ArrayList();
 		
 		if (suggestionValues != null) {
 			if (suggestionValues instanceof Collection) {
@@ -111,10 +111,11 @@
 			for (Iterator <SelectItem> iterator = selectItems.iterator(); iterator.hasNext();) {
 				SelectItem selectItem = iterator.next();
 				String value = getConvertedStringValue(context, comboBox, selectItem.getValue());
-				valuesList.add(value);
+				values.add(value);
 				encodeSuggestion(writer, comboBox, value, RICH_COMBOBOX_ITEM_CLASSES);
 			}
 		}
+		setValuesList(values);
 	}
 	
 	@Override
@@ -222,9 +223,6 @@
 	}
 
 	public List getValuesList() {
-		if (valuesList == null) {
-			valuesList = new ArrayList();
-		}
 		return valuesList;
 	}