[rules-dev] SessionConfiguration implementation issues

[Pablo Nussembaum]

Hi all,
I'm working on drools spring and I've come upon some issues in
SessionConfiguration that are stopping/confusing me.
Here are my lists of doubts/concerns about SessionConfiguration:

1) It stores 2 properties using Option instances variables and the rest
inside a ChainedProperties class.
2) There is no way no way to know what props are in the
ChainedProperties from outside the SessionConfiguration.
3) When the SessionConfiguration is immutable, it's still possible to
add more Properties using the addProperties method.
4) The ChainedProperties class is add only, in other words it isn't
possible change props values. Moreover it's also possible to have two
props with different values.

I'm attaching a patch that fix some these issues. I've updated
SessionConfiguration (g|s)etProperty(String name) method and added the
ability to ChainedProperties update existing props.

WDYT?
-- 
Bauna




-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.txt
Url: http://lists.jboss.org/pipermail/rules-dev/attachments/20091210/4011b051/attachment.txt