<div dir="ltr"><span style="font-family:arial,sans-serif;font-size:12.727272033691406px">Some notes on this approach and the current state:</span><br style="font-family:arial,sans-serif;font-size:12.727272033691406px"><ul style="font-family:arial,sans-serif;font-size:12.727272033691406px">
<li style="margin-left:15px"><b>All common felix properties have been extracted to the droolsjbpm-parent pom.</b> Individual modules should not define any of these specifically.</li><ul style><li style="margin-left:15px">
If you want to add/remove/change any of those, change them in the parent pom only:</li><ul style><li style="margin-left:15px"><a href="https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/blob/master/pom.xml" target="_blank">https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/blob/master/pom.xml</a><br>
</li></ul><li style="margin-left:15px">These are currently in the parent pom:</li><ul style><li style="margin-left:15px"><extensions>true</extensions></li><li style="margin-left:15px"><excludeDependencies>true</excludeDependencies><br>
</li><li style="margin-left:15px"><<div style="display:inline;height:auto;width:auto">_removeheaders</div>_removeheaders>Ignore-Package</_removeheaders></li><ul style><li style="margin-left:15px">What does this mean? Christiano wants to remove this.</li>
<li style="margin-left:15px">@charles are you ok with removing this?<br></li></ul></ul><li style><br></li><li style>>> <_removeheaders> allow to clean OSGI Metadata generated in the MANIFEST file. This option will remove here Ignore-Package. If such info does not appear in the MANIFEST generated, I'm fine to remove it</li>
<li style><br></li><ul style><li style="margin-left:15px"><_nouses>true</_nouses></li><ul style><li style="margin-left:15px">What does this mean? Christiano wants this.<br></li></ul></ul><li style>>> No diea</li>
<li style><br></li><ul style><li style="margin-left:15px"><_snapshot>${osgi-version-qualifier}</_snapshot></li><ul style><li style="margin-left:15px">Christiano: "To make eclipse happy"<br></li></ul>
<li style="margin-left:15px"><Bundle-Version>${parsedVersion.majorVersion}.${parsedVersion.minorVersion}.${parsedVersion.incrementalVersion}.${osgi.version.qualifier}</Bundle-Version></li><ul style><li style="margin-left:15px">
Christiano: "To make eclipse happy"</li></ul></ul></ul><ul style><li style="margin-left:15px">There are not added (because less code is better maintainable):<br></li><ul style><li style="margin-left:15px"><DynamicImport-Package>*</> has been removed everywhere, as per Christiano's change</li>
<ul style><li style="margin-left:15px">@charles @christiano If you need it anyway, edit the droolsjbpm-parent pom and supply a pull request</li><li style="margin-left:15px"><br></li></ul></ul><li style>>> If no classes are created dynamically, then we don't need it. But it we required that we add it. To be investigated later on.</li>
<li style><br></li></ul><ul style><li style="margin-left:15px"><Bundle-ActivationPolicy>lazy</> has not been added anywhere, as Charles didn't seem to need it<br></li><ul style><li style="margin-left:15px">
@christiano @charles If you need it anyway, edit the droolsjbpm-parent pom and supply a pull request</li></ul><li style>>> I was not aware of that option and we don't use it for karaf, camel, servicemix, cxf or activemq</li>
</ul><li style><br></li><li style="margin-left:15px">Generally, christiano's imports/export statements survived. (I found they to contain little or no dead imports/exports.)</li><ul style><li style="margin-left:15px">
Some of Charles imports/export statement changes were added too.</li><li style="margin-left:15px">The original state of the imports/exports was mostly ignored as they were totally out-of-date.</li></ul><li style>>> Will make a new test to verify</li>
<li style="margin-left:15px">The singleton discussion is lost to me. As Charles is supplying the unit test in droolsjbpm, I believe he should make the call which modules should be singleton and which should not, taking Christiano's advice into consideration of course.<br>
</li><ul style><li style="margin-left:15px">Some modules currently have singleton=true, others don't. This seems to be the way you guys wanted: it's differs per module</li><ul style><li style="margin-left:15px">Pull Request to add/remove singleton as needed welcome</li>
</ul><li style>>> We don't need this option singleton:=true</li><li style><br></li></ul><li style="margin-left:15px">Empty<Private-Package> have been removed everywhere</li><li style="margin-left:15px"><Require-Bundle> has been removed everywhere.</li>
<ul style><li style="margin-left:15px">This makes our build and release procedure far less complex (no more separate osgi.version property).</li><ul style><li style="margin-left:15px">Don't add it back pls: I strongly prefer it stays dead.</li>
<li style="margin-left:15px">>> This is a good practice to avoid to use Require-Bundle</li></ul></ul></ul></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Mar 26, 2013 at 12:54 PM, Geoffrey De Smet <span dir="ltr"><<a href="mailto:ge0ffrey.spam@gmail.com" target="_blank">ge0ffrey.spam@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Christiano, Charles,<br>
<br>
Your pull requests conflicted massively with each other :(<br>
<br>
I 've done my best to apply the best of both worlds.<br>
Due to the conflict, changes might be lost. Sorry if that has
happened.<br>
Contradicting conflicts have been written below.<br>
<br>
Some notes on this approach and the current state:<br>
<ul>
<li><b>All common felix properties have been extracted to the
droolsjbpm-parent pom.</b> Individual modules should not
define any of these specifically.</li>
<ul>
<li>If you want to add/remove/change any of those, change them
in the parent pom only:</li>
<ul>
<li><a href="https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/blob/master/pom.xml" target="_blank">https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/blob/master/pom.xml</a><br>
</li>
</ul>
<li>These are currently in the parent pom:</li>
<ul>
<li><extensions>true</extensions></li>
<li><excludeDependencies>true</excludeDependencies><br>
</li>
<li><_removeheaders>Ignore-Package</_removeheaders></li>
<ul>
<li>What does this mean? Christiano wants to remove this.</li>
<li>@charles are you ok with removing this?<br>
</li>
</ul>
<li><_nouses>true</_nouses></li>
<ul>
<li>What does this mean? Christiano wants this.<br>
</li>
</ul>
<li><_snapshot>${osgi-version-qualifier}</_snapshot></li>
<ul>
<li>Christiano: "To make eclipse happy"<br>
</li>
</ul>
<li><Bundle-Version>${parsedVersion.majorVersion}.${parsedVersion.minorVersion}.${parsedVersion.incrementalVersion}.${osgi.version.qualifier}</Bundle-Version></li>
<ul>
<li>Christiano: "To make eclipse happy"</li>
</ul>
</ul>
</ul>
<ul>
<li>There are not added (because less code is better
maintainable):<br>
</li>
<ul>
<li><DynamicImport-Package>*</> has been removed
everywhere, as per Christiano's change</li>
<ul>
<li>@charles @christiano If you need it anyway, edit the
droolsjbpm-parent pom and supply a pull request<br>
</li>
</ul>
</ul>
</ul>
<ul>
<ul>
<li><Bundle-ActivationPolicy>lazy</> has not been
added anywhere, as Charles didn't seem to need it<br>
</li>
<ul>
<li>@christiano @charles If you need it anyway, edit the
droolsjbpm-parent pom and supply a pull request</li>
</ul>
</ul>
</ul>
<li>Generally, christiano's imports/export statements survived. (I
found they to contain little or no dead imports/exports.)</li>
<ul>
<li>Some of Charles imports/export statement changes were added
too.</li>
<li>The original state of the imports/exports was mostly ignored
as they were totally out-of-date.</li>
</ul>
<li>The singleton discussion is lost to me. As Charles is
supplying the unit test in droolsjbpm, I believe he should make
the call which modules should be singleton and which should not,
taking Christiano's advice into consideration of course.<br>
</li>
<ul>
<li>Some modules currently have singleton=true, others don't.
This seems to be the way you guys wanted: it's differs per
module</li>
<ul>
<li>Pull Request to add/remove singleton as needed welcome</li>
</ul>
</ul>
<li>Empty<Private-Package> have been removed everywhere</li>
<li><Require-Bundle> has been removed everywhere.</li>
<ul>
<li>This makes our build and release procedure far less complex
(no more separate osgi.version property).</li>
<ul>
<li>Don't add it back pls: I strongly prefer it stays dead.<br>
</li>
</ul>
</ul>
</ul>
<p>I've now spend a lot of time on drools OSGi, and I really need to
focus on optaplanner issues.<br>
Edson has agreed to look into future osgi related pull requests
for drools.<br>
</p>
<br>
</div>
<br>_______________________________________________<br>
rules-dev mailing list<br>
<a href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Charles Moulliard</div>
<div>Apache Committer / Sr. Enterprise Architect (RedHat)</div><div>Twitter : @cmoulliard | Blog : <a href="http://cmoulliard.blogspot.com" target="_blank">http://cmoulliard.blogspot.com</a></div><div><br></div>
</div>