Working on the sign contributer agreement. Have to fill out the permission slip at the company I work for to contribute back in my free time. <br><br>I submitted at merge request <a href="https://github.com/droolsjbpm/drools/pull/102" target="_blank">https://github.com/droolsjbpm/drools/pull/102</a> <br>
<br>If the commit looks fine but just waiting on the <a href="http://www.athico.com/Getting_Involved/gettinginvolved.html#d0e319" target="_blank">Contributor Agreement</a> . If there is something I did wrong in the commit or comment just looking for feedback. <br>
<br><br><br>Just going to add the // /* to the array to test it. <br><br>Yeah I didn't test the // with 5.3.0 but I am pretty sure it happens in latest master . <br><br>I was going to use the commit <a href="https://github.com/benbennett/drools/commit/d5325b93589aafdfaeb1f45077eb4da3a8970a2f">https://github.com/benbennett/drools/commit/d5325b93589aafdfaeb1f45077eb4da3a8970a2f</a> . <br>
<br>And add // and /* to the array to cycle through. <br><br><br><br><br><br><br><div class="gmail_quote">2012/2/28 Mark Proctor <span dir="ltr"><<a href="mailto:mproctor@codehaus.org" target="_blank">mproctor@codehaus.org</a>></span><br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><div>
On 27/02/2012 15:44, Benjamin Bennett wrote:
<blockquote type="cite">I had created issue JBRULES-3399 for the issue. I
tracked it a bit , it is any comment. <br>
<br>
// or /* , think the lexar expression for comment isn't correct .
<br>
<br>
I am working towards a fix but not a antlr expert. I have used
yacc.<br>
</blockquote></div>
just a reminder to read this page, on how to correctly comment your
commits, how to submit pull requests etc:<br>
<a href="http://www.athico.com/Getting_Involved/gettinginvolved.html" target="_blank">http://www.athico.com/Getting_Involved/gettinginvolved.html</a><span><font color="#888888"><br>
<br>
Mark</font></span><div><div><br>
<blockquote type="cite">
<br>
<br>
<br>
<div class="gmail_quote">On Mon, Feb 27, 2012 at 1:38 AM, Wolfgang
Laun <span dir="ltr"><<a href="mailto:wolfgang.laun@gmail.com" target="_blank">wolfgang.laun@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Submitted: JBRULES-3401.<br>
<br>
-W<br>
<div>
<div><br>
<br>
On 24/02/2012, Benjamin Bennett <<a href="mailto:benbennett@gmail.com" target="_blank">benbennett@gmail.com</a>>
wrote:<br>
> Just passing on I am using the drools 5.4.0Beta2<br>
><br>
> The following doesn't compile using the mvel dialect
.<br>
> rule "some rule"<br>
> when<br>
> fact: Fact()<br>
> then<br>
> BasicFact fault= new BasicFact( "/*");<br>
> end<br>
><br>
> but<br>
> rule "some rule"<br>
> when<br>
> fact: Fact()<br>
> then<br>
> BasicFact fault= new BasicFact( "/ *");<br>
> end<br>
><br>
> does compile some how /* is being parsed as an
expression I think and not a<br>
> string literal.<br>
><br>
> Thanks,<br>
> Ben<br>
><br>
</div>
</div>
_______________________________________________<br>
rules-users mailing list<br>
<a href="mailto:rules-users@lists.jboss.org" target="_blank">rules-users@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
</blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
Sincerely,<br>
<br>
Benjamin Bennett<br>
<a href="tel:314.246.0645" value="+13142460645" target="_blank">314.246.0645</a><br>
<a href="mailto:benbennett@gmail.com" target="_blank">benbennett@gmail.com</a><br>
<br>
"For a successful technology, reality must take precedence over
public relations, for Nature cannot be fooled."<br>
Richard Feynman<br>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
rules-users mailing list
<a href="mailto:rules-users@lists.jboss.org" target="_blank">rules-users@lists.jboss.org</a>
<a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a>
</pre>
</blockquote>
<br>
</div></div></div>
<br>_______________________________________________<br>
rules-users mailing list<br>
<a href="mailto:rules-users@lists.jboss.org" target="_blank">rules-users@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Sincerely,<br><br>Benjamin Bennett<br><a href="tel:314.246.0645" value="+13142460645" target="_blank">314.246.0645</a><br><a href="mailto:benbennett@gmail.com" target="_blank">benbennett@gmail.com</a><br>
<br>"For a successful technology, reality must take precedence over public relations, for Nature cannot be fooled."<br>
Richard Feynman<br>