[seam-commits] Seam SVN: r9819 - in trunk: src/wicket/org/jboss/seam/wicket/web and 1 other directory.

[seam-commits at lists.jboss.org]

Author: cpopetz
Date: 2008-12-22 15:00:37 -0500 (Mon, 22 Dec 2008)
New Revision: 9819

Removed:
   trunk/src/wicket/org/jboss/seam/wicket/web/WicketExceptionFilter.java
Modified:
   trunk/doc/Seam_Reference_Guide/en-US/Wicket.xml
Log:
JBSEAM-3730: WicketExceptionFilter is problematic

Modified: trunk/doc/Seam_Reference_Guide/en-US/Wicket.xml
===================================================================
--- trunk/doc/Seam_Reference_Guide/en-US/Wicket.xml	2008-12-22 16:49:56 UTC (rev 9818)
+++ trunk/doc/Seam_Reference_Guide/en-US/Wicket.xml	2008-12-22 20:00:37 UTC (rev 9819)
@@ -271,15 +271,36 @@
          <para>
             Seam automatically installs the Wicket filter for you (ensuring that
             it is inserted in the correct place for you). But you still need to 
-            tell Wicket which <code>WebApplication</code> class to use:
+            tell Wicket which <code>WebApplication</code> class to use. 
          </para>
          
          <programlisting role="XML"><![CDATA[<components xmlns="http://jboss.com/products/seam/components"
-   xmlns:wicket="http://jboss.com/products/seam/wicket">
+ xmlns:wicket="http://jboss.com/products/seam/wicket"
+ xsi:schemaLocation=
+  "http://jboss.com/products/seam/wicket
+   http://jboss.com/products/seam/wicket-2.1.xsd">
+   
+  <wicket:web-application 
+    application-class="org.jboss.seam.example.wicket.WicketBookingApplication" />
+</components]]></programlisting>
          
-   <wicket:web-application application-class="org.jboss.seam.example.wicket.WicketBookingApplication" />
+         <para>
+          In addition, if you plan to use JSF-based pages in the same application as wicket pages, you'll 
+          need to ensure that the jsf exception filter is only enabled for jsf urls:
+         </para>
+          
+                   <programlisting role="XML"><![CDATA[<components xmlns="http://jboss.com/products/seam/components"
+ xmlns:web="http://jboss.com/products/seam/web"
+ xmlns:wicket="http://jboss.com/products/seam/wicket"
+ xsi:schemaLocation=
+  "http://jboss.com/products/seam/web
+   http://jboss.com/products/seam/web-2.1.xsd">
+     
+    <!-- Only map the seam jsf exception filter to jsf paths, which we identify with the *.seam path -->
+	<web:exception-filter url-pattern="*.seam"/>
 </components]]></programlisting>
-         
+          
+          
          <tip>
             <para>
                Take a look at the Wicket documentation for more on authorization

Deleted: trunk/src/wicket/org/jboss/seam/wicket/web/WicketExceptionFilter.java
===================================================================
--- trunk/src/wicket/org/jboss/seam/wicket/web/WicketExceptionFilter.java	2008-12-22 16:49:56 UTC (rev 9818)
+++ trunk/src/wicket/org/jboss/seam/wicket/web/WicketExceptionFilter.java	2008-12-22 20:00:37 UTC (rev 9819)
@@ -1,45 +0,0 @@
-package org.jboss.seam.wicket.web;
-
-import static org.jboss.seam.annotations.Install.FRAMEWORK;
-import static org.jboss.seam.ScopeType.APPLICATION;
-
-import java.io.IOException;
-
-import javax.servlet.FilterChain;
-import javax.servlet.ServletException;
-import javax.servlet.ServletRequest;
-import javax.servlet.ServletResponse;
-
-import org.jboss.seam.annotations.Install;
-import org.jboss.seam.annotations.Name;
-import org.jboss.seam.annotations.Scope;
-import org.jboss.seam.annotations.intercept.BypassInterceptors;
-import org.jboss.seam.annotations.web.Filter;
-import org.jboss.seam.web.AbstractFilter;
-
-/**
- * Disable the exception filter when using Wicket (as JSF is an EE library, we
- * can't rely on classDependencies to disable it)
- * @author 
- */
- at Scope(APPLICATION)
- at Name("org.jboss.seam.web.exceptionFilter")
- at Install(precedence = FRAMEWORK, classDependencies="org.apache.wicket.Application")
- at BypassInterceptors
- at Filter()
-public class WicketExceptionFilter extends AbstractFilter 
-{
-   
-   
-   @Override
-   public boolean isDisabled()
-   {
-      return true;
-   }
-
-   public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException
-   {
-      
-      
-   }
-}