[seam-dev] To cascade or not...

[Max Rydahl Andersen]

Hey,

Last week I "fixed" Hibernate tools by adding support for controlling cascade, insert, update and a few other things on associations.
In that progress I noticed that the reverse engineering were setting all collection associations cascade to "all" and not "none" which I believe would be the better to avoid surprises.

I changed it to 'none' since our hbm.xml generation were not generating cascade at that point anyway, but of course when coming to seam-gen we use annotations and in here CascadeType.ALL were being output - with the new hibernate tools no cascade is set because CascadeType.NONE is the default.

This is of course a change in the semantics of generation and I just want to check what we would *really* like to do...

1) does this change actually break seam-gen in any way ? (I don't think so because all assocations is explicitly updated anyway (afaics))

2) What default do you think we should use for reveng, ALL or NONE (or something else ?)

p.s. A swift reply would be appreciated since we are going for a GA build within a few days ;)

p.p.s. If we find a better default I can add a checkbox in the tools to enable to old default if needed.

p.p.p.s. For Pete: The bug I mentioned last night was simply another indentifier misspelling we found that for some
reason hadn't been patched in our build - so that is a separate issue I'm trying to find the cause for in https://jira.jboss.org/jira/browse/JBIDE-3880

Thanks,
Max