[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-537) conversation lock not unlocked

[Norman Richards (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBSEAM-537?page=comments#action_12347862 ] 
            
Norman Richards commented on JBSEAM-537:
----------------------------------------

I've fixed the immediate problem in AbstractSeamPhaseListener.java by checking to see if the exception is a handled exception.  If it is handled, we don't need to worry about it.  The code rethrows unhandled exceptions, which still will result in the conversation lock not being released.  Gavin - you'll have too look at that condition and decide how you want to handle it, if you think it is a problem.

> conversation lock not unlocked
> ------------------------------
>
>                 Key: JBSEAM-537
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-537
>             Project: JBoss Seam
>          Issue Type: Bug
>    Affects Versions: 1.1.0.CR2
>            Reporter: Norman Richards
>             Fix For: 1.1.0.CR2
>
>
> If a page action results in an exception, the lock on the ConversationEntry is never unlocked.   If the debug page is called after that, the conversation can only be restored if the request happens to be on the same thread as the original request.   If the conversation cannot be restored, the conversation state and the last exception will not be displayed. 
> Refreshing the page a few times may help because JBoss is likely to cycle through the threads, ultimately landing the request back on the original thread, allowing the reentrant lock to be acquired and the conversation restored.  I don't entirely understand the conversation locking strategy, so I can't suggest a fix.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira