[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1151) Embedded plugin Facelets drop values during postback

[Pete Muir (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBSEAM-1151?page=comments#action_12358956 ] 
            
Pete Muir commented on JBSEAM-1151:
-----------------------------------

I've made a commit that should fix all of the above.  It parses the wikitext and creates UIWikiFormattedText components for non-plugins and does a facelet's include for plugins (and also adds in a UIStyle component to render the css inline).  I created a UIPlugin component that should be the root component of a plugin (all it does for now is extend UINamingContainer to keep your ids unique so you can include the same plugin multiple times).  This seems to work for the comment plugin (though it might have broken the interactive preview...).  I think it might have broken the layout stuff as well.

Discuss further on IM...

> Embedded plugin Facelets drop values during postback
> ----------------------------------------------------
>
>                 Key: JBSEAM-1151
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
>             Project: JBoss Seam
>          Issue Type: Bug
>          Components: Wiki
>            Reporter: Christian Bauer
>         Assigned To: Pete Muir
>            Priority: Blocker
>
> Pete, as discussed on IM and posted here so we can coordinate what needs to be done:
> The wiki includes Facelets manually into the facelet tree when a plugin is encountered during page rendering. This is done in two phases, through a ComponentHandler when the facelet tree is build and through a custom component that renders the HTML for the tree manually. This seems to work fine visually, and the view tree looks OK.
> However, if such an included facelet contains a form, on postback of this form the tree is rebuild during RENDER RESPONSE and any invalid component from the earlier VALIDATIONS phase is lost. So we never see entered invalid values in the form again. This can be tested with the "user comment" form on the wiki.
> The interesting thing here is that it works perfectly fine for the plugin settings forms, you can see those if you edit a document, and enable the preview and plugin settings checkboxes. These forms are much more complicated than the "user comment" form, so I haven't touched them to find out why it works in that case. The trivial "user comment" form should be easier to debug...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira