[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1151) Embedded plugin Facelets drop values during postback
Christian Bauer (JIRA)
jira-events at lists.jboss.org
Mon Apr 16 03:51:58 EDT 2007
[ http://jira.jboss.com/jira/browse/JBSEAM-1151?page=comments#action_12359385 ]
Christian Bauer commented on JBSEAM-1151:
OK, so the issue is that the separate UIWikiFormattedText components don't work. There is no guarantee that a [<=plugin] is in the wiki source without any dependency on outer wiki tags. E.g.:
"A Plugin: <div>[<=plugin]</div>"
doesn't work because you get three components in the tree:
<UIWikiFormattedText value="A Plugin: <div>"/>
The last UIWikiFormattedText can't render "</div>" properly because the wiki text parser mangles the closing </div> if there is no opening <div> before. This might be solved with a different HTML passthrough parsing approach but I'm not sure that this is the way to go. What about plugins that are not divs, e.g. a plugin that is rendered really inline as a <span>:
"This is a *[<=pluginRenderedAsSpan]* with a bold span around it."
> Embedded plugin Facelets drop values during postback
> Key: JBSEAM-1151
> URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
> Project: JBoss Seam
> Issue Type: Bug
> Components: Wiki
> Reporter: Christian Bauer
> Assigned To: Pete Muir
> Priority: Blocker
> Pete, as discussed on IM and posted here so we can coordinate what needs to be done:
> The wiki includes Facelets manually into the facelet tree when a plugin is encountered during page rendering. This is done in two phases, through a ComponentHandler when the facelet tree is build and through a custom component that renders the HTML for the tree manually. This seems to work fine visually, and the view tree looks OK.
> However, if such an included facelet contains a form, on postback of this form the tree is rebuild during RENDER RESPONSE and any invalid component from the earlier VALIDATIONS phase is lost. So we never see entered invalid values in the form again. This can be tested with the "user comment" form on the wiki.
> The interesting thing here is that it works perfectly fine for the plugin settings forms, you can see those if you edit a document, and enable the preview and plugin settings checkboxes. These forms are much more complicated than the "user comment" form, so I haven't touched them to find out why it works in that case. The trivial "user comment" form should be easier to debug...
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the seam-issues