[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1151) Embedded plugin Facelets drop values during postback
Pete Muir (JIRA)
jira-events at lists.jboss.org
Tue Apr 17 18:08:30 EDT 2007
[ http://jira.jboss.com/jira/browse/JBSEAM-1151?page=comments#action_12359632 ]
Pete Muir commented on JBSEAM-1151:
Christian, I've committed another version of the Handler. The handler now creates a component tree for the plugin, and puts a placeholder in the wikitext. When the UIWikiFormattedText does it's encodeBegin, when it encounters a plugin, it will use the placeholder to look up the client id of the plugin and render it. This appears to be working for all the the welcome page and the blog page. A couple of notes - 1) I haven't got it to autowire attributes, these have to be wired in the setAttributes method of the handler. 2) I've used a4j's style component for rendering the styles for the plugins - this causes a <link src="" /> tag to be added to the head for each plugin that needs a stylesheet - it is resolving EL inside the CSS - but not for the EVENT or PAGE scope - if you want this, we would need to write out a <style> rather than a link.
The latest version of jboss-el fixes the function problem.
Can you give it a test?
> Embedded plugin Facelets drop values during postback
> Key: JBSEAM-1151
> URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
> Project: JBoss Seam
> Issue Type: Bug
> Components: Wiki
> Reporter: Christian Bauer
> Assigned To: Pete Muir
> Priority: Blocker
> Pete, as discussed on IM and posted here so we can coordinate what needs to be done:
> The wiki includes Facelets manually into the facelet tree when a plugin is encountered during page rendering. This is done in two phases, through a ComponentHandler when the facelet tree is build and through a custom component that renders the HTML for the tree manually. This seems to work fine visually, and the view tree looks OK.
> However, if such an included facelet contains a form, on postback of this form the tree is rebuild during RENDER RESPONSE and any invalid component from the earlier VALIDATIONS phase is lost. So we never see entered invalid values in the form again. This can be tested with the "user comment" form on the wiki.
> The interesting thing here is that it works perfectly fine for the plugin settings forms, you can see those if you edit a document, and enable the preview and plugin settings checkboxes. These forms are much more complicated than the "user comment" form, so I haven't touched them to find out why it works in that case. The trivial "user comment" form should be easier to debug...
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the seam-issues