[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-880) Make UISelectItems more permissive to null-values

[Peter Muir (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBSEAM-880?page=comments#action_12353509 ] 
            
Peter Muir commented on JBSEAM-880:
-----------------------------------

We can certainly document more clearly that a not-null value is required.  Though this should really go in the Seam taglib doc, which is currently an outstanding bug ;)

However I don't agree that we should start adding in empty lists (this IMO is just plain confusing).  I think what should be happening is that if we cannot process the value in UISelectItems (i.e. it's null or not something we can interpret) we pass the value on unmodified.  I guess the alternative would be to add an empty list and add either a WARN message to the log or a FacesMessage.  Thoughts?

> Make UISelectItems more permissive to null-values
> -------------------------------------------------
>
>                 Key: JBSEAM-880
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-880
>             Project: JBoss Seam
>          Issue Type: Patch
>          Components: JSF
>    Affects Versions: 1.1.7.GA
>            Reporter: Guy Veraghtert
>         Assigned To: Peter Muir
>            Priority: Minor
>             Fix For: 1.1.7.GA
>
>         Attachments: patch-880.txt
>
>
> The method createSelectItems(Object value) in UISelectItems is not permissive to null-values; a framework class should not die on NPE.
> This can be fixed by assigning an empty list to value when value == null

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira