[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1537) set hibernate.dialect explicitly in persistence-*.xml

[Dan Allen (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBSEAM-1537?page=comments#action_12368817 ] 
            
Dan Allen commented on JBSEAM-1537:
-----------------------------------

Hmm, good point, I will do that. However, I might argue that even with that in place, you may want to customize. For instance, Hibernate has several dialects for MySQL. Depending on what database you are using against seam-gen, you may want to tweak the dialect to your needs.

Of course, you could argue that seam-gen is about getting sensible defaults and you can always go and add the dialect to the persistence-*.xml files after running the generator. You tell me. I'm really not sure which way to go.

> set hibernate.dialect explicitly in persistence-*.xml
> -----------------------------------------------------
>
>                 Key: JBSEAM-1537
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-1537
>             Project: JBoss Seam
>          Issue Type: Patch
>          Components: Tools
>    Affects Versions: 1.3.0.ALPHA
>         Environment: seam CVS HEAD
>            Reporter: Dan Allen
>            Priority: Minor
>         Attachments: JBSEAM-1537-v1.txt
>
>   Original Estimate: 5 minutes
>  Remaining Estimate: 5 minutes
>
> The seam-gen setup asks the user for hibernate.dialect, but then does not pass it on to the generated persistence-*.xml files. It's fun to take things in faith, but in this case it probably isn't worth it.  Hibernate can autodetect the dialect from the driver class most of the time, but it could be wrong or the lookup may be missing (as in the case of the H2 database).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira