[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1041) Pages: isLoginRedirectRequired should be called before applying request parameter values

[Darryl Smith (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBSEAM-1041?page=comments#action_12369241 ] 
            
Darryl Smith commented on JBSEAM-1041:
--------------------------------------

When using page parameters with converters

When the first request hits storeRequestParameterValuesInViewRoot is called which converters the page parameter into Object

Redirect to login occurs

Login

storeRequestParameterValuesInViewRoot is called again, and calls converter getAsObject with previously converted parameter Object.toString()

> Pages: isLoginRedirectRequired should be called before applying request parameter values
> ----------------------------------------------------------------------------------------
>
>                 Key: JBSEAM-1041
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-1041
>             Project: JBoss Seam
>          Issue Type: Bug
>          Components: Security
>    Affects Versions: 1.2.0.GA
>            Reporter: Darryl Smith
>         Assigned To: Gavin King
>             Fix For: 2.0.0.CR1
>
>
> Seam will apply page parameters before it does the checks to see if login redirection is required.
> This is problematic for applications rely on session scope information created in authenticator being present
> e.g. using @In(scope=SESSION) currentUser, or using @In(scope=SESSION) Identity identity, or any factory that depends on identity information
> 12:16:53,383 ERROR [DebugPageHandler] redirecting to debug page
> org.jboss.seam.RequiredException: In attribute requires non-null value: userBrowseQueryFactory.currentUser
> 	at org.jboss.seam.Component.getValueToInject(Component.java:1887)
> 	at org.jboss.seam.Component.injectAttributes(Component.java:1336)
> 	at org.jboss.seam.Component.inject(Component.java:1163)
> 	at org.jboss.seam.interceptors.BijectionInterceptor.aroundInvoke(BijectionInterceptor.java:46)
> 	at org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:69)
> 	at org.jboss.seam.interceptors.MethodContextInterceptor.aroundInvoke(MethodContextInterceptor.java:27)
> 	at org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:69)
> 	at org.jboss.seam.intercept.RootInterceptor.invoke(RootInterceptor.java:103)
> 	at org.jboss.seam.intercept.JavaBeanInterceptor.interceptInvocation(JavaBeanInterceptor.java:154)
> 	at org.jboss.seam.intercept.JavaBeanInterceptor.intercept(JavaBeanInterceptor.java:89)
> 	at edu.uga.ais.piac.pva.action.user.UserBrowseQueryFactory$$EnhancerByCGLIB$$5ef43164.setFirstResult(<generated>)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> 	at java.lang.reflect.Method.invoke(Method.java:585)
> 	at org.apache.myfaces.el.PropertyResolverImpl.setProperty(PropertyResolverImpl.java:406)
> 	at org.apache.myfaces.el.PropertyResolverImpl.setValue(PropertyResolverImpl.java:173)
> 	at org.apache.myfaces.el.ValueBindingImpl.setValue(ValueBindingImpl.java:275)
> 	at org.jboss.seam.core.Expressions$1.setValue(Expressions.java:67)
> 	at org.jboss.seam.core.Pages.applyRequestParameterValues(Pages.java:608)
> 	at org.jboss.seam.jsf.AbstractSeamPhaseListener.beforeRender(AbstractSeamPhaseListener.java:176)
> 	at org.jboss.seam.jsf.SeamPhaseListener.beforePhase(SeamPhaseListener.java:57)
> 	at org.apache.myfaces.lifecycle.PhaseListenerManager.informPhaseListenersBefore(PhaseListenerManager.java:70)
> 	at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:373)
> 	at javax.faces.webapp.FacesServlet.service(FacesServlet.java:138)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira